Bug 830182
| Summary: | Review Request: perl-Array-Base - Array index offsetting | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-11 13:46:06 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Jitka Plesnikova
2012-06-08 13:19:49 UTC
Source file is original. Ok.
Summary verified from lib/Array/Base.pm. Ok.
License verified from lib/Array/Base.pm. Ok.
Description verified from lib/Array/Base.pm. Ok.
URL and Source0 are useable. Ok.
Conflicts verified from Build.PL. Ok.
TODO: Qualify `perl(Test::Pod)' with `>= 1.00' (t/pod_syn.t:5).
All tests pass. Ok.
$ rpmlint perl-Array-Base.spec ../SRPMS/perl-Array-Base-0.005-1.fc18.src.rpm ../RPMS/x86_64/perl-Array-Base-*
perl-Array-Base.src: W: spelling-error %description -l en_US indices -> induces, indies, indicts
perl-Array-Base.x86_64: W: spelling-error %description -l en_US indices -> induces, indies, indicts
3 packages and 1 specfiles checked; 0 errors, 2 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/x86_64/perl-Array-Base-0.005-1.fc18.x86_64.rpm
drwxr-xr-x 2 root root 0 Jun 11 10:01 /usr/lib64/perl5/vendor_perl/Array
-rw-r--r-- 1 root root 6037 Jun 11 10:01 /usr/lib64/perl5/vendor_perl/Array/Base.pm
drwxr-xr-x 2 root root 0 Jun 11 10:01 /usr/lib64/perl5/vendor_perl/auto/Array
drwxr-xr-x 2 root root 0 Jun 11 10:01 /usr/lib64/perl5/vendor_perl/auto/Array/Base
-rwxr-xr-x 1 root root 14392 Jun 11 10:01 /usr/lib64/perl5/vendor_perl/auto/Array/Base/Base.so
drwxr-xr-x 2 root root 0 Jun 11 10:01 /usr/share/doc/perl-Array-Base-0.005
-rw-r--r-- 1 root root 2805 Feb 1 17:53 /usr/share/doc/perl-Array-Base-0.005/Changes
-rw-r--r-- 1 root root 1072 Feb 1 17:53 /usr/share/doc/perl-Array-Base-0.005/README
-rw-r--r-- 1 root root 4221 Jun 11 10:01 /usr/share/man/man3/Array::Base.3pm.gz
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-Array-Base-0.005-1.fc18.x86_64.rpm |sort |uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 perl(Lexical::SealRequireHints) >= 0.006
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/x86_64/perl-Array-Base-0.005-1.fc18.x86_64.rpm |sort |uniq -c
1 perl(Array::Base) = 0.005
1 perl-Array-Base = 0.005-1.fc18
1 perl-Array-Base(x86-64) = 0.005-1.fc18
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/x86_64/perl-Array-Base-0.005-1.fc18.x86_64.rpm
Binary dependencies resolvable. Ok.
Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4148000). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Please consider fixing `TODO' items before building the package.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-Array-Base Short Description: Array index offsetting Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. |