Bug 830421

Summary: Review Request: python-django-pylibmc - Django cache backend using pylibmc
Product: [Fedora] Fedora Reporter: Praveen Kumar <kumarpraveen.nitdgp>
Component: Package ReviewAssignee: Matthias Runge <mrunge>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bugs.michael, notting, package-review
Target Milestone: ---Flags: mrunge: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-17 19:09:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 736776    

Description Praveen Kumar 2012-06-09 12:30:59 UTC
Spec URL: http://kumarpraveen.fedorapeople.org/django-pylibmc/python-django-pylibmc.spec

SRPM URL: http://kumarpraveen.fedorapeople.org/django-pylibmc/python-django-pylibmc-0.2.3-1.20120609git28874f.fc17.src.rpm

Description: Django-pylibmc package provides a memcached cache backend for Django using pylibmc. You want to use pylibmc because it's fast.

Fedora Account System Username: kumarpraveen

koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=4143236

Comment 1 Matthias Runge 2012-06-25 18:45:31 UTC
Package Review
==============

Key:
- = N/A
x = Pass
! = Fail
? = Not evaluated



==== Generic ====
[x]: MUST Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: MUST Package successfully compiles and builds into binary rpms on at
     least one supported primary architecture.
[x]: MUST %build honors applicable compiler flags or justifies otherwise.
[x]: MUST All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: MUST Buildroot is not present
     Note: Unless packager wants to package for EPEL5 this is fine
[x]: MUST Package contains no bundled libraries.
[x]: MUST Changelog in prescribed format.
[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: Clean would be needed if support for EPEL is required
[x]: MUST Sources contain only permissible code or content.
[x]: MUST Each %files section contains %defattr if rpm < 4.4
     Note: Note: defattr macros not found. They would be needed for EPEL5
[x]: MUST Macros in Summary, %description expandable at SRPM build time.
[x]: MUST Package does not require other packages for directories it uses.
[x]: MUST Package uses nothing in %doc for runtime.
[x]: MUST Package is not known to require ExcludeArch.
[x]: MUST Permissions on files are set properly.
[x]: MUST Package does not contain duplicates in %files.
[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf would be needed if support for EPEL5 is required
[-]: MUST Large documentation files are in a -doc subpackage, if required.
[x]: MUST If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %doc.
[x]: MUST License field in the package spec file matches the actual license.
[x]: MUST Package consistently uses macros (instead of hard-coded directory
     names).
[x]: MUST Package is named according to the Package Naming Guidelines.
[x]: MUST Package does not generate any conflict.
[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
[!]: MUST Package must own all directories that it creates.
[x]: MUST Package does not own files or directories owned by other packages.
[x]: MUST Package installs properly.
[x]: MUST Requires correct, justified where necessary.
[!]: MUST Rpmlint output is silent.

rpmlint python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.src.rpm

python-django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python-django-pylibmc.src: W: spelling-error %description -l en_US memcached -> schemed
python-django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end
python-django-pylibmc.src: W: invalid-url Source0: python-django-pylibmc-0.2.3.20120609git28874f.tar.xz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm

python-django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python-django-pylibmc.noarch: W: spelling-error %description -l en_US memcached -> schemed
python-django-pylibmc.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


[x]: MUST Sources used to build the package match the upstream source, as
     provided in the spec URL.
Package has no sources or they are generated by developer
[x]: MUST Spec file is legible and written in American English.
[x]: MUST Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[-]: MUST Package contains a SysV-style init script if in need of one.
[x]: MUST File names are valid UTF-8.
[x]: MUST Useful -debuginfo package or justification otherwise.
[x]: SHOULD Reviewer should test that the package builds in mock.
[x]: SHOULD If the source package does not include license text(s) as a
     separate file from upstream, the packager SHOULD query upstream to
     include it.
[x]: SHOULD Dist tag is present.
[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
     /usr/sbin.
[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
     --requires).
[?]: SHOULD Package functions as described.
[x]: SHOULD Latest version is packaged.
[x]: SHOULD Package does not include license text files separate from
     upstream.
[x]: SHOULD SourceX is a working URL.
[x]: SHOULD Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: SHOULD Package should compile and build into binary rpms on all supported
     architectures.
[!]: SHOULD %check is present and all tests pass.
[x]: SHOULD Packages should try to preserve timestamps of original installed
     files.
[x]: SHOULD Spec use %global instead of %define.

Issues:
[!]: MUST Rpmlint output is silent.

rpmlint python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.src.rpm

python-django-pylibmc.src: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python-django-pylibmc.src: W: spelling-error %description -l en_US memcached -> schemed
python-django-pylibmc.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end
python-django-pylibmc.src: W: invalid-url Source0: python-django-pylibmc-0.2.3.20120609git28874f.tar.xz
1 packages and 0 specfiles checked; 0 errors, 4 warnings.


rpmlint python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm

python-django-pylibmc.noarch: W: spelling-error Summary(en_US) backend -> backed, back end, back-end
python-django-pylibmc.noarch: W: spelling-error %description -l en_US memcached -> schemed
python-django-pylibmc.noarch: W: spelling-error %description -l en_US backend -> backed, back end, back-end
1 packages and 0 specfiles checked; 0 errors, 3 warnings.


See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint


Issues:
- you don't include the dirs in files section. (hint: leave out the trailing slash!)
- there's a check included upstream. You should use it.

Comment 2 Michael Schwendt 2012-06-25 19:39:42 UTC
Please notice the MUST items at
  http://fedoraproject.org/wiki/Package_Renaming_Process
which affect both the packager and the reviewer.

[...]

$ yum search django-avatar django-pylibmc
Loaded plugins: auto-update-debuginfo, langpacks, presto, refresh-packagekit
========================== N/S Matched: django-avatar ==========================
django-avatar.noarch : A django module for handling user avatars

========================= N/S Matched: django-pylibmc ==========================
django-pylibmc.noarch : Django cache backend using pylibmc

Comment 3 Matthias Runge 2012-06-26 06:42:07 UTC
OK, thank you Michael, for the reminder.


[mrunge@mrungexp review]$ rpm -qp --provides /var/lib/mock/fedora-rawhide-i386/result/python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm 
django-pylibmc = 0.2.3-1.20120609git28874f.fc18
python-django-pylibmc = 0.2.3-1.20120609git28874f.fc18



[mrunge@mrungexp review]$ rpm -qp --requires /var/lib/mock/fedora-rawhide-i386/result/python-django-pylibmc-0.2.3-1.20120609git28874f.fc18.noarch.rpm 
python(abi) = 2.7
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

no python-django? I have missed that in my review.

obsoletes: obsoletes the latest version before the rename. (OK)

Comment 5 Matthias Runge 2012-07-02 09:08:19 UTC
OK, finally
package APPROVED

Comment 6 Praveen Kumar 2012-07-02 14:38:17 UTC
New Package SCM Request
=======================
Package Name: python-django-pylibmc
Short Description: Django cache backend using pylibmc
Owners: kumarpraveen
Branches: devel

Comment 7 Gwyn Ciesla 2012-07-02 15:04:00 UTC
Git done (by process-git-requests).

Comment 8 Matthias Runge 2012-08-17 19:09:37 UTC
ok, it's built and imported.