Bug 831001

Summary: netatalk pam configuration has invalid entry
Product: [Fedora] Fedora Reporter: Scott Shambarger <scott-fedora>
Component: netatalkAssignee: Lukáš Nykrýn <lnykryn>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: lnykryn
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: netatalk-2.2.2-2.fc17 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-30 22:01:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Fix comment in netatalk.pam-system-auth none

Description Scott Shambarger 2012-06-11 22:17:07 UTC
Created attachment 591033 [details]
Fix comment in netatalk.pam-system-auth

Description of problem:
The following errors appear in log/secure:

PAM (netatalk) illegal module type: user
PAM pam_parse: expecting return value; [...context]

Version-Release number of selected component (if applicable):
netatalk-2.2.2-1.fc17

How reproducible:
Always

Steps to Reproduce:
1. Configure netatalk to authenticate connections (eg '-uamlist uams_dhx2.so' in afpd.conf)
2. Attempt to connect to afpd server
3. Examine log/secure
  
Actual results:
PAM parse errors as displayed above.

Expected results:
No PAM errors

Additional info:
This appears to be a typo in the netatalk.pam-system-auth in the source package, where a comment was incorrectly wrapped to a newline.  I've supplied a patch to fix the comment.

Comment 1 Lukáš Nykrýn 2012-06-12 07:45:56 UTC
Thanks for the patch.
committed to git->http://lists.fedoraproject.org/pipermail/scm-commits/2012-June/802338.html->modified

Comment 2 Fedora Update System 2012-06-12 07:49:36 UTC
netatalk-2.2.2-2.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/netatalk-2.2.2-2.fc17

Comment 3 Scott Shambarger 2012-06-12 08:32:39 UTC
2.2.2-2 appears to work as expected.

I did notice that upgrading the package didn't restart the daemon as I expected... perhaps the spec file needs a few extra lines (these are inspired from bind.spec, should I log a separate bug?):

%preun
if [ "$1" -eq 0 ] ; then
  # Package removal, not upgrade
  /bin/systemctl --no-reload disable netatalk.service > /dev/null 2>&1 || :
  /bin/systemctl stop netatalk.service > /dev/null 2>&1 || :
fi
:;

%postun
/sbin/ldconfig
/bin/systemctl daemon-reload >/dev/null 2>&1 || :
if [ "$1" -ge 1 ] ; then
  # Package upgrade, not uninstall
  /bin/systemctl try-restart netatalk.service >/dev/null 2>&1 || :
fi
:;

Comment 4 Lukáš Nykrýn 2012-06-12 08:46:02 UTC
There is only missing '# Package upgrade, not uninstall' part in spec. I will fix it in rawhide, but if you think that this should be also fixed in F17 please file a bug so I won't forget it in next update.

Comment 5 Scott Shambarger 2012-06-12 09:11:05 UTC
Probably not important for this update since pam is dynamic loading.  Good to hear it'll be in F18 though :)

Comment 6 Fedora Update System 2012-06-13 21:34:23 UTC
Package netatalk-2.2.2-2.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing netatalk-2.2.2-2.fc17'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-9327/netatalk-2.2.2-2.fc17
then log in and leave karma (feedback).

Comment 7 Scott Shambarger 2012-06-23 00:08:00 UTC
Left feedback over a week ago, this can probably go stable.

Comment 8 Fedora Update System 2012-06-30 22:01:50 UTC
netatalk-2.2.2-2.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.