Bug 831039

Since we symlink is this really an issue?

The answer I got from Kroberts:
problem is that in the installer, it doesn't seem to be appending the user and password to that conf file. You can see that the LC RPM contains the conf file...

keith - can you please elaborate?
if changing this, need to require rhev > 3.1 since 3.0 doesn't have this folder, or have backward compatible protective code.
as long as we symlink, i'd just close this for now.

Symlink isn't really even necessary for any of the 3 tools I maintain.  They've all been updated to use /etc/ovirt-engine/.

This BZ came out of a debug session with David.  I looked in /etc/ and didn't see a /etc/ovirt-engine/.  The fact that this directory didn't exist and didn't contain the .conf files for the LC, ISO uploader, and image uploader, caused him to get prompted for user IDs.

I'm not sure what happened but I see the directories now on his system and they do contain the requisite conf files.

David, the only thing that you might want to check is if the installer correctly appends the following 2 lines to each config file.  In particular, you need to check that...
/etc/ovirt-engine/<logcollector.conf | isouploader.conf | imageuploader.conf> 
all get updated.  If they are not updated, the tools will prompt you in certain scenarios.

[root@dbotzer-installation ~]# tail -3 /etc/ovirt-engine/logcollector.conf 
#pg-ssh-user=root
rhevm=<hostname given to installer during install>:<port given to installer>
user=admin@internal <-- User ID given to installer.

keith - do the new tools require rhevm > 3.1?
else they won't find any /etc/ovirt-engine, etc.

Hi Keith,
I tested it now on 3.1/si6
the three files are logcollector/imageuploader/isouploader
Please advise,

[Correct]
tail -3 logcollector.conf 
#pg-ssh-user=root
rhevm=xxxx-vm-jrs7.qa.lab.tlv.redhat.com:443
user=admin@internal
----------------------------------------
[ERROR]
[root@xxxx-JRS7 ovirt-engine]# tail -3 imageuploader.conf 
## supply this option if you want to rename the template name (i.e. Name) of the image
#template-name=TEMPLATE_NAME
----------------------------------------
[Correct]
tail -3 isouploader.conf 

rhevm=xxxx-jrs7.qa.lab.tlv.redhat.com:443
user=admin@internal

(In reply to comment #6)
> Hi Keith,
<snip>
> ----------------------------------------
> [ERROR]
> [root@xxxx-JRS7 ovirt-engine]# tail -3 imageuploader.conf 
> ## supply this option if you want to rename the template name (i.e. Name) of
> the image
> #template-name=TEMPLATE_NAME
> ----------------------------------------
So this is a bug.  Installer needs to append this information to the end of the .conf file.  

In reponse to comment 5, I didn't pin the new tools to '> 3.1' but it is a logical safety check.  Also, this only needs to be corrected downstream.  Upstream tools have always looked in /etc/ovirt-engine; hence, no need to change spec file there.

There really isn't a LC, ISO uploader or Image Uploader bug here.  The only bug that I see is the fact that the installer isn't appending the hostname, port, and user information to the end of imageuploader.conf during install.  

I'm going to move this to the installer component as this issue needs to be fixed there.

This issue was solved in bz788079.

*** This bug has been marked as a duplicate of bug 788079 ***