Bug 831654
| Summary: | Update RHEL 5.x to NSPR 4.9.1 for Mozilla 10.0.6 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Elio Maldonado Batiz <emaldona> | ||||||
| Component: | nspr | Assignee: | Elio Maldonado Batiz <emaldona> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | BaseOS QE Security Team <qe-baseos-security> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.9 | CC: | amarecek, jjaburek, jpallich, jrieden, kengert, ksrot, rrelyea, swadeley | ||||||
| Target Milestone: | rc | Keywords: | ZStream | ||||||
| Target Release: | 5.9 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | nspr-4.9.1-4.el5 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-01-08 07:39:02 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 830304, 834220 | ||||||||
| Attachments: |
|
||||||||
|
Description
Elio Maldonado Batiz
2012-06-13 14:13:55 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux release for currently deployed products. This request is not yet committed for inclusion in a release. Created attachment 593108 [details]
For the record: the changes made for the nspr 4.9.1 update
The bulk of the changes come as the result of uptream supplying us with the nspr.pc.in file. The rather tricky sed editing on our own copy in the %install section of nspr.spec isn no longer need. I still do some light patching.
To see the effect of on nspr-devel rpm and compare against the last one that shipped download both rpms, extract them and compare the relevant pieces.
The last one shipped
$ rpmdev-extract ~/Downloads/nspr-devel-4.8.9-1.el5.x86_64.rpm
nspr-devel-4.8.9-1.el5.x86_64/usr/bin/nspr-config
... ommitted ....
nspr-devel-4.9.1-1.el5.x86_64/usr/lib64/pkgconfig/nspr.pc
Extract the one just built
$ rpmdev-extract ~/Downloads/nspr-devel-4.9.1-1.el5.x86_64.rpm
nspr-devel-4.9.1-1.el5.x86_64/usr/bin/nspr-config
... ommitted ....
nspr-devel-4.9.1-1.el5.x86_64/usr/lib64/pkgconfig/nspr.pc
$ diff -up nspr-devel-4.8.9-1.el5.x86_64/usr/bin/nspr-config nspr-devel-4.8.9-1.el5.x86_64/usr/bin/nspr-config
--- identical as expected
]$ diff -up nspr-devel-4.8.9-1.el5.x86_64/usr/lib64/pkgconfig/nspr.pc nspr-devel-4.9.1-1.el5.x86_64/usr/lib64/pkgconfig/nspr.pc
--- nspr-devel-4.8.9-1.el5.x86_64/usr/lib64/pkgconfig/nspr.pc 2012-02-08 15:00:15.000000000 -0800
+++ nspr-devel-4.9.1-1.el5.x86_64/usr/lib64/pkgconfig/nspr.pc 2012-06-19 12:36:07.000000000 -0700
@@ -1,12 +1,10 @@
-ldflags=
-os_libs=-lpthread -ldl
prefix=/usr
-exec_prefix=/usr
+exec_prefix=${prefix}
libdir=/usr/lib64
includedir=/usr/include/nspr4
Name: NSPR
Description: The Netscape Portable Runtime
-Version: 4.8.9
-Libs: -L/usr/lib64 -lplds4 -lplc4 -lnspr4 -lpthread -ldl
+Version: 4.9.1
+Libs: -L/usr/lib64/nspr4 -lplds4 -lplc4 -lnspr4 -lpthread -ldl
Cflags: -I/usr/include/nspr4
Created attachment 593509 [details]
Remove the unwanted /nspr4 part
Comment on attachment 593509 [details]
Remove the unwanted /nspr4 part
This means your patch adds @OS_LIBS@
I don't know what this will expand to, do you?
It expands to '-lpthread -ldl', the last on the answer to kg-config --libs nspr which I need to preserve. By the way, that old have nspr-config-vars.in has ldflags=@LDFLAGS@ os_libs=@OS_LIBS@ and helped accompish the same things in a circuituous manner, new way is simpler. I restored the top part of to the original nspr-config-pc.patch that patches nspr-congig which I had mistankey removed. Without it we would have had a multilib regression. The rpmdiff based test caught that. Red Hat should run the set of tests that involves all applications that make use of NSPR/NSS to verify there are no regressions. back to modified for inclusion of 633519 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0081.html Since this is not a single issue / something that can/should be automatically tested itself, I'm setting qe_test_coverage- to exclude this bug from automatic cleanup checker. |