Bug 832393

Summary: VIP users no longer allowed to launch medium/large gear sizes
Product: OKD Reporter: Xiaoli Tian <xtian>
Component: PodAssignee: Abhishek Gupta <abhgupta>
Status: CLOSED CURRENTRELEASE QA Contact: libra bugs <libra-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 1.xCC: bmeng, rmillner
Target Milestone: ---Keywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-25 18:27:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
jenkins server log none

Description Xiaoli Tian 2012-06-15 10:10:26 UTC 
Created attachment 592097 [details]
jenkins server log

Description of problem:
Jenkins client which were added to old jboss app use medium gear size for slave builder, it could be built successfully with jenkins before if there are medium size profile.(Change profile to medium if in single node). but now even if the profile has been changed to medium, it will always fail, log in jenkins server is:
"Caused by: com.openshift.express.internal.client.httpclient.BadRequestException: {"exit_code":134,"data":"","api":"1.1.3","debug":"","result":"Invalid Size: medium.  Must be: small.  Please contact support for access to additional sizes.","messages":"","api_c":["placeholder"],"broker_c":["namespace","rhlogin","ssh","app_uuid","debug","alter","cartridge","cart_type","action","app_name","api"]}"


Even if after set user to vip, it still failed with the same error.for even if I'm vip, my gear size is still small
rhc-admin-ctl-user  -l xtian+t00 --setvip true

User xtian+t00:
      consumed gears: 4
           max gears: 20
          vip status: true
          gear sizes: small


It will be successful after add medium gear size to the user like below
rhc-admin-ctl-user  -l xtian+t00 --addgearsize medium

User xtian+t00:
      consumed gears: 4
           max gears: 20
          vip status: true
          gear sizes: small, medium


The newkly added jenkins client will not be affected since bug 828762 has changed all default size to small.

Version-Release number of selected component (if applicable):
devenv-stage_217

How reproducible:
Always

Steps to Reproduce:
1.Launch an devenv-stage_217
2.create an jboss app with jenkins enabled
3.git push to build
4.update it and migrate it
5.git push to build
  
Actual results:
Step 3 and Step 5 all failed, not sure if some changes already pulled in devenv-stage_217

Expected results:
Step3 and Step 5 should be sucessful

Additional info:
Comment 1 Xiaoli Tian 2012-06-15 13:04:16 UTC 
Jbosseap6 are still using medium profile, so if user who do not have medium gear size will fail to build it with jenkins.
Comment 2 Rob Millner 2012-06-15 17:54:52 UTC 
There's a number of new jboss/jenkins bugs this morning; we may have to revert back to medium gear sized being the default.
Comment 3 Rob Millner 2012-06-15 19:24:24 UTC 
It looks like the real issue is that the "VIP" user status was replaced by a specific list of allowed gear sizes and it no longer works.

Changing the title and moving the bug.
Comment 4 Abhishek Gupta 2012-06-15 22:29:40 UTC 
This bug was introduced when we introduced "capabilities". Since new users are now being created with "small" as the capabilities.gear_sizes, we needed this fix.
Comment 5 Meng Bo 2012-06-18 09:47:02 UTC 
Verified on latest devenv_1850, issue has been fixed.

User bmeng+1:
      consumed gears: 25
           max gears: 100
          vip status: true
          gear sizes: small

User can create medium size gear after enable VIP flag.