Bug 832727
| Summary: | Review Request: python-django-addons - A framework to create pluggable Django add-ons | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Domingo Becker <domingobecker> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-19 22:15:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 736776 | ||
|
Description
Domingo Becker
2012-06-16 21:14:13 UTC
I'll take this one. - I think that BR: python-setuptools-devel should be python-setuptools, shouldn't it? - rpmlint is reporting filesize mismatch. Could you redownload the package and create new SRPM? python-django-addons.src: W: file-size-mismatch django-addons-0.6.4.tar.gz = 15567, http://pypi.python.org/packages/source/d/django-addons/django-addons-0.6.4.tar.gz = 15958 - There are some things that are only needed for EPEL 5, do you plan to build your package there, too? Otherwise you can remove them: BuildRoot tag, %clean section, rm -rf $RPM_BUILD_ROOT, %defattr(-,root,root,-) Otherwise the package looks good, so once you fix these issues, please post the updated SPEC/SRPM here so I can have a final look and approve the package. (In reply to comment #2) > - I think that BR: python-setuptools-devel should be python-setuptools, > shouldn't it? > - rpmlint is reporting filesize mismatch. Could you redownload the package > and create new SRPM? > > python-django-addons.src: W: file-size-mismatch django-addons-0.6.4.tar.gz = > 15567, > http://pypi.python.org/packages/source/d/django-addons/django-addons-0.6.4. > tar.gz = 15958 > Fixed. > - There are some things that are only needed for EPEL 5, do you plan to > build your package there, too? Otherwise you can remove them: BuildRoot tag, > %clean section, rm -rf $RPM_BUILD_ROOT, %defattr(-,root,root,-) > Fixed. New spec and srpm: Spec URL: http://beckerde.fedorapeople.org/transifex/python-django-addons.spec SRPM URL: http://beckerde.fedorapeople.org/transifex/python-django-addons-0.6.4-7.fc18.src.rpm There is one more line that can be removed: "BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". Please remove it before commiting to dist-git.
Otherwise everything looks good, this package is APPROVED.
New Package SCM Request ======================= Package Name: python-django-addons Short Description: A framework to create pluggable Django add-ons Owners: beckerde Branches: InitialCC: diegobz Git done (by process-git-requests). (In reply to comment #4) > There is one more line that can be removed: "BuildRoot: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)". Please > remove it before commiting to dist-git. > > Otherwise everything looks good, this package is APPROVED. Done. Many thanks. |