Bug 832999
| Summary: | Review Request: colord-gtk - GTK support library for colord | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Hughes <rhughes> |
| Component: | Package Review | Assignee: | Debarshi Ray <debarshir> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | debarshir, notting, package-review |
| Target Milestone: | --- | Flags: | rhughes:
fedora-review?
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-27 08:37:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard Hughes
2012-06-18 11:23:51 UTC
There is a typo in the %description. It says: "colord is a support library for colord ...". Should be "colord-gtk is a ...". (In reply to comment #1) > There is a typo in the %description. It says: "colord is a support library > for colord ...". Should be "colord-gtk is a ...". I've replaced it with %{name}, thanks. :) * libcolord-gtk/cd-sample-window.[ch] & client/cd-convert.c are under GPLv2+ according to their respective license notices. Also COPYING has the text of the GPLv2 instead of LGPLv2.
* You don't really need to specify glib2-devel as a BuildRequires because it is going to be pulled in by gtk3-devel, gobject-introspection-devel, colord-devel, etc.. But it is up to you.
* ColordGtk-1.0.gir should be part of the devel package and %{_libdir}/girepository-1.0/ColordGtk-1.0.typelib should be part of the base package.
* The devel package should own %{_datadir}/gir-1.0.
* The devel package should own %{_datadir}/gtk-doc and %{_datadir}/gtk-doc/html, but not %{_datadir}/gtk-doc/data. The other alternative is to Require: gtk-doc, but it is better to avoid it.
* You could mark %{_datadir}/gtk-doc/html/colord-gtk as %doc
* %defattr(-,root,root,-) is not needed these days.
(http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions)
* It is better to require the base package from the devel package as:
Requires: %{name}%{?_isa} = %{version}-%{release}
(http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage)
(In reply to comment #3) > * libcolord-gtk/cd-sample-window.[ch] & client/cd-convert.c are under GPLv2+ > according to their respective license notices. Also COPYING has the text of > the GPLv2 instead of LGPLv2. Both fixed upstream, thanks. > * You don't really need to specify glib2-devel as a BuildRequires because it > is going to be pulled in by gtk3-devel, gobject-introspection-devel, > colord-devel, etc.. But it is up to you. I'd rather include this, as i can dep on a higher version of glib if I need to in the future. > * ColordGtk-1.0.gir should be part of the devel package and > %{_libdir}/girepository-1.0/ColordGtk-1.0.typelib should be part of the base > package. My mistake, fixed. > * The devel package should own %{_datadir}/gir-1.0. Fixed. > * The devel package should own %{_datadir}/gtk-doc and > %{_datadir}/gtk-doc/html, but not %{_datadir}/gtk-doc/data. The other > alternative is to Require: gtk-doc, but it is better to avoid it. Fixed. > * You could mark %{_datadir}/gtk-doc/html/colord-gtk as %doc Fixed. > * %defattr(-,root,root,-) is not needed these days. > (http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions) Fixed. > * It is better to require the base package from the devel package as: > Requires: %{name}%{?_isa} = %{version}-%{release} > (http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage) Fixed. New builds: Spec URL: http://people.freedesktop.org/~hughsient/temp/colord-gtk.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/colord-gtk-0.1.22-1.fc17.src.rpm Thanks for the review :) + COPYING has LGPLv3, which is probably just a mistake. In that case omit it from the package for the time being, and restore it when it contains the correct text. Probably with the next upstream release. (http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text) +----------+ | APPROVED | +----------+ New Package SCM Request ======================= Package Name: colord-gtk Short Description: GTK support library for colord Owners: rhughes Branches: f17 InitialCC: rhughes Git done (by process-git-requests). Built for F17 and rawhide, thanks! |