Bug 833411
Summary: | Review Request: realmd - Kerberos realm enrollment service | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Stef Walter <stefw> |
Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | mclasen, notting, package-review, yaneti |
Target Milestone: | --- | Flags: | yaneti:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-07-13 15:41:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Stef Walter
2012-06-19 12:41:42 UTC
try rpmlint on the result: (here is an excerpt) realmd.x86_64: E: explicit-lib-dependency PackageKit-glib realmd.x86_64: E: explicit-lib-dependency glib2 realmd.x86_64: E: explicit-lib-dependency krb5-libs realmd.x86_64: W: incoherent-version-in-changelog 0.3 ['0.3-1.fc18', '0.3-1'] You don't need to include explicit deps on shared libraries which will be picked up by the rpm dep generator. Also from BuildRequires: automake libtool intltool pkgconfig you only need intltool Unless you auto(make/conf/reconf). Explicit BuildRoot: tag is not needed since a release or two ago. Same for %defattr(-,root,root,-) Same for the explicit rm -f %{buildroot} in the start of %clean or %install Group: is obosolete You should own %{_libdir}/realmd, as in %dir %{_libdir}/realmd and %dir %{_libdir}/realmd/provider.d and %doc AUTHORS COPYING ChangeLog NEWS README seems like a better fit than empty docs I've looked through some of the source files and they all look like LGPLv2+ not LGPLv2 (In reply to comment #1) > try rpmlint on the result: (here is an excerpt) Oddly enough, my rpmlint doesn't show those warnings: [stef@stef-rawhide rpm]$ rpmlint SPECS/realmd.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. > realmd.x86_64: E: explicit-lib-dependency PackageKit-glib > realmd.x86_64: E: explicit-lib-dependency glib2 > realmd.x86_64: E: explicit-lib-dependency krb5-libs > realmd.x86_64: W: incoherent-version-in-changelog 0.3 ['0.3-1.fc18', '0.3-1'] > > You don't need to include explicit deps on shared libraries which will be > picked up by the rpm dep generator. Interesting. Thanks, removed them. > Also from > BuildRequires: automake libtool intltool pkgconfig > you only need intltool Unless you auto(make/conf/reconf). We do run pkg-config, or is that build requirement automatically provided? > Explicit BuildRoot: tag is not needed since a release or two ago. > Same for %defattr(-,root,root,-) > Same for the explicit rm -f %{buildroot} in the start of %clean or %install > Group: is obosolete Removed all those lines. > You should own %{_libdir}/realmd, as in > %dir %{_libdir}/realmd > and > %dir %{_libdir}/realmd/provider.d Done. (In reply to comment #2) > and %doc AUTHORS COPYING ChangeLog NEWS README > seems like a better fit than empty docs Done. (In reply to comment #3) > I've looked through some of the source files and they all look like LGPLv2+ > not LGPLv2 Thanks, updated the License: line. Updated spec file: http://people.freedesktop.org/~stefw/rpm/realmd.spec New SRPM: http://people.freedesktop.org/~stefw/rpm/realmd-0.3-2.fc17.src.rpm (In reply to comment #4) > (In reply to comment #1) > > try rpmlint on the result: (here is an excerpt) > > Oddly enough, my rpmlint doesn't show those warnings: > > [stef@stef-rawhide rpm]$ rpmlint SPECS/realmd.spec > 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Probably because you've only tried it on the spec. Try it on the spec, srpm, built rpms and even the debuginfo. Here are additional errors it finds here. rpmlint-1.4-6.fc17.noarch realmd.x86_64: E: incorrect-fsf-address /usr/share/doc/realmd-0.3/COPYING realmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/realmd-0.3/service/realm-command.c realmd-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/realmd-0.3/service/realm-command.h > > Also from > > BuildRequires: automake libtool intltool pkgconfig > > you only need intltool Unless you auto(make/conf/reconf). > We do run pkg-config, or is that build requirement automatically provided? Its currently required by rpm-build which is in the minimal build root http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 I think it should be in the Expections list but, but its fine if it stays. I don't personally think the fsf address thing can be considered a blocker. There is still a lingering Requires: polkit Also I would approve the package and sponsor you, but I am not in the sponsors group. Thanks. Fixed various rpmlint warnings, and removed polkit dep. Uploaded new spec and packages here: http://stefw.fedorapeople.org/rpm/realmd/ I am a sponsor, and can sponsor you. Package looks good. APPROVED Thanks guys. New Package SCM Request ======================= Package Name: realmd Short Description: realmd is a dbus system service which manages discovery and enrollment in realms and domains like Active Directory or IPA. Owners: stefw Branches: InitialCC: baz Git done (by process-git-requests). Removed baz, not a valid FAS account. This was built and is already in rawhide. stefw , on your next package review please close the bug when its built and on its way to the repo. Alright. Will do. |