Bug 833787
| Summary: | ovirt-engine-backend: we are able to add a disk during create snapshot | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Virtualization Manager | Reporter: | Dafna Ron <dron> | ||||||
| Component: | ovirt-engine | Assignee: | mkublin <mkublin> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Dafna Ron <dron> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | urgent | ||||||||
| Version: | 3.1.0 | CC: | abaron, amureini, bazulay, dyasny, iheim, mkublin, Rhev-m-bugs, yeylon, ykaul | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | 3.1.0 | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | storage | ||||||||
| Fixed In Version: | SI8 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | Bug | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
not solved I was still able to create the disk while snapshot was created. logs attached Created attachment 594196 [details]
log
I don't see any problm at logs, just clog for creating disk recheck at si8, I suppose the fix was not there verified on si8 |
Created attachment 593180 [details] log Description of problem: since snapshot is on entire vm and not just the disks, and we cancelled the image lock on vm during snapshot we should add a CanDoAction on add disk while disk images are locked due to snapshot to prevent possible races which will cause image corruption. Version-Release number of selected component (if applicable): si6 How reproducible: 100% Steps to Reproduce: 1. create a snapshot 2. create a new disk 3. Actual results: vm is not locked only disk images and there is no CanDoAction -> new disk will be created while a snapshot is taken. Expected results: we should add CanDoAction to add disk if the disk images are locked due to snapshot. Additional info:backend log