Bug 834338
Summary: | SECURITY: kgrantpty: unnecessary setuid root binary | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | H. Peter Anvin <hpa> |
Component: | kdelibs3 | Assignee: | Than Ngo <than> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 23 | CC: | gholms, jgrulich, kevin, rdieter, smparrish, than |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2016-06-27 15:04:36 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
H. Peter Anvin
2012-06-21 15:15:29 UTC
s/attack vector/attack surface/ as i remember correctly kgrantpty is intended to be used internally by konsole to open a slave pty securely, it performs a setuid chmod and chown on the slave pty device. Hmmm, kdelibs3 is a compatibility library, making unnecessary changes in it might break things. Are we sure really nothing expects kgrantpty to be there? Have you tried deleting it and then trying legacy kdelibs3 programs to check that they still work? (In particular, if you find anything using the old KonsolePart from kdebase3, that'd be worth testing.) If it's really unnecessary, we can delete it, but I'd like to be reasonably sure that there aren't any legacy programs which expect it to be there. Look at the source code! kgrantpty is only invoked in a single place, in KPty::chownpty(), which is a private method (not exported from the library); it in turn is only called in two places, both of which have explicit tests for Unix98 PTYs which bypass the call to chownpty(). If something outside kdelibs3 needs kgrantpty then it is a legacy application in its own right and should be packaged into a separate package. This message is a reminder that Fedora 17 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 17. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as WONTFIX if it remains open with a Fedora 'version' of '17'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version prior to Fedora 17's end of life. Bug Reporter: Thank you for reporting this issue and we are sorry that we may not be able to fix it before Fedora 17 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior to Fedora 17's end of life. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 it's fixed in kdelibs3-3.5.10-75.fc25 |