Bug 834592

Summary: libvirt-guest.service works backwards
Product: [Fedora] Fedora Reporter: Simo Sorce <ssorce>
Component: libvirtAssignee: Michal Privoznik <mprivozn>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: berrange, clalancette, dallan, dougsland, eblake, isomorphix, itamar, jforbes, jyang, laine, libvirt-maint, phil, veillard, virt-maint
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-27 16:17:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Simo Sorce 2012-06-22 14:11:24 UTC
I noticed my VM were killed at reboot and I was advice to enable libvirt-guest.service to have them saved automatically.

Unfortunately it seem this service is backwards or enabled from the wrong target.
'start' saved the VMs, 'stop' seem to do nothing.
This means that at shutdown VMs are still mercilessly killed.

Comment 1 Philippe Troin 2012-06-22 17:02:10 UTC
I'm running into the same problem as Simo.

After poring through the systemd logs, this is what I believe happens on my systems:

- libvirtd.service starts and keeps running
- libvirt-guests.service starts, see there is nothing to do (by default), then exits successfully.
- systemd seeing that the service has terminated successfully calls the stop target
- libvirt-guests.service tries to shutdown all the VMs, but fails as they are still in the BIOS or booting.
- libvirt-guests.service fails after 1 minute, but stays in the stopped,failed state.

Then, at real shutdown, the libvirt-guests stop action is not ran and the VMs are killed hard.

Adding:
  RemainAfterExit=yes
to the [Service] section of 
/lib/systemd/system/libvirt-guests.service
makes libvirt behave for me.

Phil.

Comment 2 Eric Blake 2012-07-27 16:17:30 UTC

*** This bug has been marked as a duplicate of bug 843836 ***