Bug 835051
| Summary: | Review Request: perl-Module-Install-AutoLicense - Module::Install extension to automatically generate LICENSE files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Šabata <psabata> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, psabata, tcallawa |
| Target Milestone: | --- | Flags: | psabata:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-28 14:40:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 835062 | ||
|
Description
Jitka Plesnikova
2012-06-25 11:11:31 UTC
perl(Module::Install::GithubMeta) is only required in inc/Module/Install/GithubMeta.pm which is removed during %setup; I believe you could drop it from your BRs. The rest seems good to me. Approving. perl(Module::Install::GithubMeta) is required for Makefile.PL, because it uses the function githubmeta. New Package SCM Request ======================= Package Name: perl-Module-Install-AutoLicense Short Description: Module::Install extension to automatically generate LICENSE files Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig Git done (by process-git-requests). Thank you for the review and the repository. Package Change Request ====================== Package Name: perl-Module-Install-AutoLicense New Branches: f16 f17 Owners: jplesnik mmaslano ppisar psabata InitialCC: perl-sig Git done (by process-git-requests). |