Bug 835617

Summary: Review Request: roundcubemail-plugins-kolab - Kolab plugins for Roundcube
Product: [Fedora] Fedora Reporter: Jeroen van Meeuwen <vanmeeuwen+fedora>
Component: Package ReviewAssignee: Christoph Wickert <cwickert>
Status: ASSIGNED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, zdenek
Target Milestone: ---Flags: cwickert: fedora‑review?
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:

Description Jeroen van Meeuwen 2012-06-26 11:32:38 EDT
Spec URL: http://git.kolabsys.com/rpm/roundcubemail-plugins-kolab/plain/roundcubemail-plugins-kolab.spec
SRPM URL: http://mirror.kolabsys.com/pub/fedora/kolab-3.0/f17/development/SRPMS/roundcubemail-plugins-kolab-3.0-0.11.fc17.kolab_3.0.src.rpm
Description: Kolab Groupware plugins for the Roundcube webmail interface, enabling Roundcube to use Calendars and Addressbooks stored on a Kolab server.
Fedora Account System Username: kanarip
Comment 1 Jon Ciesla 2012-06-26 12:01:06 EDT
Initial notes:


See the following for proper git snapshot versioning.

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages

roundcubemail-plugins-kolab.spec:22: W: unversioned-explicit-obsoletes roundcubemail-kolab
The specfile contains an unversioned Obsoletes: token, which will match all
older, equal and newer versions of the obsoleted thing.  This may cause update
problems, restrict future package/provides naming, and may match something it
was originally not inteded to match -- make the Obsoletes versioned if
possible.

roundcubemail-plugins-kolab.noarch: W: self-obsoletion roundcubemail-kolab obsoletes roundcubemail-kolab = 3.0-0.11.fc17

Several files in /etc/roundcubemail/ that are 640, should be 644.

roundcubemail-plugins-kolab.src: W: invalid-license GPL


Should be GPLv3+
Comment 2 Jeroen van Meeuwen 2012-06-28 08:52:27 EDT
(In reply to comment #1)
> Initial notes:
> 
> 
> See the following for proper git snapshot versioning.
> 
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages
> 

Corrected to include the date the snapshot is taken, and the short rev used.

I'm going to have to keep the 0.12 prefix and can't go with simply 0.git$date.$rev yet, as 0.11 is already out there.

For snapshots, I target to use 0.$x.git<rev> if that's OK with you.

> roundcubemail-plugins-kolab.spec:22: W: unversioned-explicit-obsoletes
> roundcubemail-kolab
> The specfile contains an unversioned Obsoletes: token, which will match all
> older, equal and newer versions of the obsoleted thing.  This may cause
> update
> problems, restrict future package/provides naming, and may match something it
> was originally not inteded to match -- make the Obsoletes versioned if
> possible.
> 

Updated to obsolete only roundcubemail-kolab < %{version}-%{release}

> roundcubemail-plugins-kolab.noarch: W: self-obsoletion roundcubemail-kolab
> obsoletes roundcubemail-kolab = 3.0-0.11.fc17
> 

Corrected by versioning the obsoletes.

> Several files in /etc/roundcubemail/ that are 640, should be 644.
> 

This is deliberate - only the apache user/group and superusers should be able to read these files (they likely contain passwords to access databases, LDAP and IMAP with privileged accounts). Other POSIX users should not have read access to these files.

> roundcubemail-plugins-kolab.src: W: invalid-license GPL
> 
> Should be GPLv3+

Corrected.

Spec URL: http://git.kolabsys.com/rpm/roundcubemail-plugins-kolab/plain/roundcubemail-plugins-kolab.spec
SRPM URL: http://mirror.kolabsys.com/pub/fedora/kolab-3.0/f17/development/SRPMS/roundcubemail-plugins-kolab-3.0-0.13.git20120628.c5c41f7f.fc17.kolab_3.0.src.rpm