Bug 835701

Summary: [as7] Error Updating cluster-connection Resource Attributes
Product: [Other] RHQ Project Reporter: Stefan Negrea <snegrea>
Component: PluginsAssignee: Stefan Negrea <snegrea>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: high    
Version: 4.4CC: ahovsepy, fbrychta, hrupp, jsanda, lzoubek, myarboro, spinder
Target Milestone: CR02   
Target Release: JON 3.1.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 831377 Environment:
Last Closed: 2013-09-03 15:12:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 831377    
Bug Blocks: 707223    
Attachments:
Description Flags
retryIntervalMultiplier_agent.log
none
retryIntervalMultiplier none

Description Stefan Negrea 2012-06-26 21:07:44 UTC 
+++ This bug was initially created as a clone of Bug #831377 +++

Description of problem:
The following configuration parameters are marked as long in the plugin descriptor but the AS7 accepts and returns decimal values.


Attribute: retry-interval-multiplier
Address: subsystem=messaging,hornetq-server=default,cluster-connection=my-cluster, name=my-cluster, parent=default


How reproducible:
Every time

Steps to Reproduce:
1. Discover and import an AS7 server
2. Find the resource described by the address noted above.
3. Attempt to update the configuration with retry-interval-multiplier as a decimal number (eg 1.5)
  
Actual results:
The UI does not allow the user to submit a configuration update request with decimal numbers. If a decimal number is read from AS7, the user is asked to correct the entry.

Expected results:
Update retry-interval-multiplier with a decimal number without any problems.


Additional info:
The user are still able to update this resource with long values.

--- Additional comment from snegrea on 2012-06-12 18:15:50 EDT ---

Updated plugin descriptor to accept decimal values for retry-interval-multiplier.
Comment 1 Stefan Negrea 2012-07-20 21:23:11 UTC 
release/jon3.1.x branch commit:

http://git.fedorahosted.org/git/?p=rhq/rhq.git;a=commit;h=3ea3c75618f4b1944ffd07a853b1df41b391642d
Comment 2 John Sanda 2012-08-02 18:52:01 UTC 
JON 3.1.1 ER1 build is available. Moving to ON_QA.

https://brewweb.devel.redhat.com/buildinfo?buildID=226942
Comment 3 Armine Hovsepyan 2012-08-06 14:52:04 UTC 
reopen.

same situation as #835696
Comment 4 Stefan Negrea 2012-08-14 19:47:24 UTC 
Please retest this. Bug 835696 received new code updates. This property update was not sent to the EAP6 server because of an earlier failure in the update process caused by bug 835696. No further code changes required for this bug.
Comment 5 John Sanda 2012-08-22 05:41:18 UTC 
Moving to ON_QA. The JON 3.1.1 ER3 build is available at https://brewweb.devel.redhat.com/buildinfo?buildID=230321.
Comment 6 Armine Hovsepyan 2012-08-23 15:21:33 UTC 
same situation as 835696 . moving back to on_dev
Comment 7 Stefan Negrea 2012-08-28 03:21:20 UTC 
Please test changing the value for the retry-interval-multiplier field in isolation as described in the description. The change is very specific to this particular field to accept decimal values. If the test fails please provide replication steps for failures.

Also 835696 is related to the infinispan susbystem and not the messaging subsystem covered by this bug.
Comment 8 Armine Hovsepyan 2012-08-28 09:15:08 UTC 
clean jon with only EAP plugin installed, started eap in full-ha mode, change of retry-interval-multiplier from 1 to 1.5 created server crash.

reopened.
Comment 9 Stefan Negrea 2012-08-29 21:08:49 UTC 
Please retest this. The underlying issue has been fixed. Update for this particular field were not broken but updates for the resource as a whole were not working properly. No changes required, other code changes resolved this issue.
Comment 10 John Sanda 2012-08-30 01:47:52 UTC 
The CR1 build is available at
https://brewweb.devel.redhat.com/buildinfo?buildID=231258. Moving to ON_QA.
Comment 11 Armine Hovsepyan 2012-08-31 09:14:44 UTC 
Created attachment 608443 [details]
retryIntervalMultiplier_agent.log
Comment 12 Armine Hovsepyan 2012-08-31 09:15:11 UTC 
Created attachment 608444 [details]
retryIntervalMultiplier
Comment 13 Armine Hovsepyan 2012-08-31 09:16:05 UTC 
reopen.

Exception on gui during the edit, exception in log during the save - value gets back to 1.0
Comment 14 Simeon Pinder 2012-08-31 18:56:32 UTC 
I was unable to reproduce this issue with the latest CR1 build.
Version: 3.1.1.CR1
Build Number: 3219830:ad1ab7d

More specifically I:
- unpacked EAP 6.0.0.GA and started standalone with -c standalone-full-ha.xml
- installed CR1 server and agent with plugin packs and imported eap instance
- set connection properties for discovery, after successful discovery navigated to the specific resource and changed config Retry Interval Multiplier from 1 -> 1.5 successfully.
- Navigated away from resource and back to verify reload successfully and double checked that value successfully persisted to as7 configuration as well.

There were no related errors in agent log or exceptions in ui.

Moving this back to ON_QA for another retest.  If there is still an issue it may be helpful to try to delete the browser cache completely and try Shift + F5 to force browser refresh.
Comment 15 Filip Brychta 2012-09-04 10:30:46 UTC 
Tested with 3.1.1.CR1 version and it's working correctly for me as well.
Comment 16 Libor Zoubek 2012-09-04 10:59:40 UTC 
Tested with 3.1.1.CR1 version and it's working correctly except for server reload - which is Bug 847869
Comment 17 Armine Hovsepyan 2012-09-04 12:35:01 UTC 
verifying this bug.

Case with reload invalid configuration still is visible, but since the value from 1 is being changed to smth like 1.5, this bug can be closed as verified and the bug#847869 is responsible for the case.

Thanks Filip, Libor.
Comment 18 Heiko W. Rupp 2013-09-03 15:12:18 UTC 
Bulk closing of old issues in VERIFIED state.