Bug 836185

Summary: Kernel package should contain sch_htb module
Product: [Fedora] Fedora Reporter: Michal Privoznik <mprivozn>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: gansalmon, itamar, jonathan, kernel-maint, madhu.chinakonda
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-07 21:54:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 835055    

Description Michal Privoznik 2012-06-28 09:53:34 UTC
Description of problem:

Libvirt has capability of setting QoS over VM interfaces. It's implemented via HTB scheduler. However, this module is not part of main kernel package but kernel-modules-extra. Since libvirt is not dependent on that package we need to move the module into the main kernel package.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. make sure kernel-modules-extra is not installed
2. define libvirt domain with QoS on an interface (see comment 1 in bug 835055)
3. virsh start $domain
4. observe failure

Alternative steps to reproduce:
1. make sure kernel-modules-extra is not installed
2. /sbin/tc qdisc add dev vnet0 root handle 1: htb default 1
   (substitute vnet0 with real NIC)
3. observe failure

  
Actual results:
Domain is not started.
Or for alternative steps: Queuing discipline cannot be created.

Expected results:
Domain can be started
Or for alternative steps: Queuing discipline is be created.

Additional info:

I don't think making libvirt dependent on kernel-modules-extra is the right path of fixing this. Because it's actually /sbin/tc which should be dependent if any. On the other hand, tc shouldn't be dependent on any QoS module. We shouldn't force users to install whole bunch of scheduling algorithms they won't even use.

Comment 1 Josh Boyer 2012-07-05 15:54:02 UTC
Fixed in F17 and rawhide.  Will be in the next build for each.

Comment 2 Fedora Update System 2012-07-05 21:56:14 UTC
kernel-3.4.4-5.fc17 has been submitted as an update for Fedora 17.
https://admin.fedoraproject.org/updates/kernel-3.4.4-5.fc17

Comment 3 Fedora Update System 2012-07-06 21:25:31 UTC
Package kernel-3.4.4-5.fc17:
* should fix your issue,
* was pushed to the Fedora 17 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing kernel-3.4.4-5.fc17'
as soon as you are able to, then reboot.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-10325/kernel-3.4.4-5.fc17
then log in and leave karma (feedback).

Comment 4 Fedora Update System 2012-07-07 21:54:48 UTC
kernel-3.4.4-5.fc17 has been pushed to the Fedora 17 stable repository.  If problems still persist, please make note of it in this bug report.