Bug 836587
| Summary: | Review Request: php-htmLawed - PHP code to purify and filter HTML | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> | ||||
| Component: | Package Review | Assignee: | Shawn Iwinski <shawn> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | notting, package-review, shawn | ||||
| Target Milestone: | --- | Flags: | shawn:
fedora-review+
gwync: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-07-14 21:55:32 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Remi Collet
2012-06-29 15:16:48 UTC
Note to reviewer : target is fedora >= 16 and EPEL >= 5 htmlLawed documentation [1] says its' license is "LGPL license version 3 and GPL license version 2 or later", but the spec file has "LGPLv3+ and GPLv2+". Shouldn't the spec file have "LGPLv3 and GPLv2+" (no "+" for LGPL)? [1] http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/htmLawed_README.htm#s1.4 Hard to say if LGPL license version 3 and GPL license version 2 or later means (LGPL license version 3 and GPL license version 2) or later or LGPL license version 3 and (GPL license version 2 or later) I have ask upstream to clarify http://www.bioinformatics.org/phplabware/forum/viewtopic.php?pid=627#p627 As http://www.bioinformatics.org/phplabware/internal_utilities/htmLawed/ says "free and licensed under LGPL v3 and GPL v2+" It seems + only apply to GPL. So https://github.com/remicollet/remirepo/commit/01690cde94c30acce0517a47375387af8b696e6d SRPM: http://rpms.famillecollet.com/SRPMS/php-htmLawed-1.1.11-2.remi.src.rpm EPEL 5 build seems to fail: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218696 I've run into this issue before when using a later SRPM for RHEL/EPEL 5 builds. Will the build succeed using "fedpkg build" from the "el5" repo branch? I'm assuming since the PHP version dependency is so low, and since you require php-ctype and php-pcre, you don't need to explicitly require php-common? Also, we should notify phpci upstream that there is a false positive of the session extension. Hum... from a local generic srpm, succeed: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218766 From a local mock el5 result srpm, also succeed: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218770 From your build log DEBUG util.py:257: error: unpacking of archive failed on file /builddir/build/SOURCES/htmLawed.zip;4ff490d7: cpio: MD5 sum mismatch So I think to a temporary issue... (In reply to comment #6) > I'm assuming since the PHP version dependency is so low, and since you > require php-ctype and php-pcre, you don't need to explicitly require > php-common? Yes. > Also, we should notify phpci upstream that there is a false positive of the > session extension. I don't see this... $ phpci print --report extension /usr/share/php/htmLawed/ ------------------------------------------------------------------------------- EXTENSION PECL VERSION COUNT ------------------------------------------------------------------------------- Core 4.0.0 27 ctype 4.0.4 3 pcre 4.0.0 54 standard 4.0.0 204 ------------------------------------------------------------------------------- Have you run phpci on the full tree sources ? (htmLawedTest.php use session, but is only provided as %doc)? (In reply to comment #8) > Have you run phpci on the full tree sources ? > (htmLawedTest.php use session, but is only provided as %doc)? Indeed I did. My mistake. Created attachment 596283 [details]
Package review (initially generated by fedora-review 0.1.3)
No issues detected === APPROVED === Thanks for the quick review. New Package SCM Request ======================= Package Name: php-htmLawed Short Description: PHP code to purify and filter HTML Owners: remi Branches: f16 f17 el5 el6 InitialCC: Git done (by process-git-requests). php-htmLawed-1.1.12-1.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/php-htmLawed-1.1.12-1.fc17 php-htmLawed-1.1.12-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/php-htmLawed-1.1.12-1.fc16 php-htmLawed-1.1.12-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-htmLawed-1.1.12-1.el5 php-htmLawed-1.1.12-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-htmLawed-1.1.12-1.el6 php-htmLawed-1.1.12-1.el5 has been pushed to the Fedora EPEL 5 testing repository. php-htmLawed-1.1.12-1.fc16 has been pushed to the Fedora 16 stable repository. php-htmLawed-1.1.12-1.fc17 has been pushed to the Fedora 17 stable repository. php-htmLawed-1.1.12-1.el6 has been pushed to the Fedora EPEL 6 stable repository. php-htmLawed-1.1.12-1.el5 has been pushed to the Fedora EPEL 5 stable repository. |