Bug 836720

Description of problem:

When creating or extending a V1 or V2 storage domain the LVMcache within vdsm provides an incorrect listing of PVs within a given VG due to a bug within the pvs command (BZ#836663). This then leads to incorrect or missing PV* entries within the metadata for a storage domain. This will become an issue when we attempt to create a vdisk with it's LV spanning or residing on this PV as we are unable to find the PV within our own storage domain metadata. This results in a 'meta data mapping failed' or MetaDataMappingError - 754 error from vdsm.

Version-Release number of selected component (if applicable):
All versions of vdsm where lvm 2.02.69 or greater is also present on the system.

How reproducible:
Always

Steps to Reproduce:
1. Create or extend a SD to hold more than a single PV.
2. Review the MD present for the PVs.
3. PV data is either missing or incorrect.
  
Actual results:
LVMcache provides LvMetadataRW or VgMetadataRW with an incorrect listing of the actual PVs present within the storage domain. This leads to either incorrect or missing PV entries in the metadata of either V1 or V2 based SDs.

Expected results:
As this is a pvs bug there are a number of things we could change here :

- Ensure pvs is always called with the PV with the active mda within the VG first.
- Stop calling pvs with the individual PVs as arguments. This would result in a complete scan but would require additional logic to ensure we only look at PVs in the VG we care about.
- Switch to using vgs -o +pv_name ${vguuid}.
- Add additional checking within LVMcache to ensure that the number of PVs reported from pvs is what we are expecting.

Additional info:

The following example is for a V2 storage domain with 5 PVs :

# vgs -o +pv_name
  VG                                   #PV #LV #SN Attr   VSize   VFree   PV                                      
  480a7532-cf70-4fc3-9341-65b9f3a0fa19   5   8   0 wz--n- 123.12g 114.25g /dev/mapper/1IET_00010002               
  480a7532-cf70-4fc3-9341-65b9f3a0fa19   5   8   0 wz--n- 123.12g 114.25g /dev/mapper/1IET_0001000a               
  480a7532-cf70-4fc3-9341-65b9f3a0fa19   5   8   0 wz--n- 123.12g 114.25g /dev/mapper/1IET_00010009               
  480a7532-cf70-4fc3-9341-65b9f3a0fa19   5   8   0 wz--n- 123.12g 114.25g /dev/mapper/1IET_00010001               
  480a7532-cf70-4fc3-9341-65b9f3a0fa19   5   8   0 wz--n- 123.12g 114.25g /dev/mapper/1IET_00010004               
  HostVG                                 1   2   0 wz--n-   1.23g      0  /dev/mapper/1ATA_QEMU_HARDDISK_QM00001p4

In my case only a single PV line was added to the VG tags :

# vgs -o +tags | grep MDT | sed -e 's/\,/\n/g' | grep PV
MDT_PV0=pv:1IET_00010002&44&uuid:hXHZco-TkdH-KDpI-XZks-AuW7-6tfQ-X9j0ws&44&pestart:0&44&pecount:197&44&mapoffset:0

When calling only pvs we see :

# pvs
  PV                                       VG                                   Fmt  Attr PSize  PFree 
  /dev/mapper/1ATA_QEMU_HARDDISK_QM00001p4 HostVG                               lvm2 a--   1.23g     0 
  /dev/mapper/1IET_00010001                480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g
  /dev/mapper/1IET_00010002                480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 15.75g
  /dev/mapper/1IET_00010004                480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g
  /dev/mapper/1IET_00010009                480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g
  /dev/mapper/1IET_0001000a                480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g

When calling pvs with each pv as an argument in the same manor as the LVMcache and also providing the PV with the MDA last we get :

# pvs /dev/mapper/1IET_0001000{1,4,9,a,2}
  PV                        VG                                   Fmt  Attr PSize  PFree 
  /dev/mapper/1IET_00010001                                      lvm2 a--  25.00g 25.00g
  /dev/mapper/1IET_00010002 480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 15.75g
  /dev/mapper/1IET_00010004                                      lvm2 a--  25.00g 25.00g
  /dev/mapper/1IET_00010009                                      lvm2 a--  25.00g 25.00g
  /dev/mapper/1IET_0001000a                                      lvm2 a--  25.00g 25.00g

Calling pvs with this PV first gives us the correct results :

# pvs /dev/mapper/1IET_0001000{2,4,9,a,1}
  PV                        VG                                   Fmt  Attr PSize  PFree 
  /dev/mapper/1IET_00010001 480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g
  /dev/mapper/1IET_00010002 480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 15.75g
  /dev/mapper/1IET_00010004 480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g
  /dev/mapper/1IET_00010009 480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g
  /dev/mapper/1IET_0001000a 480a7532-cf70-4fc3-9341-65b9f3a0fa19 lvm2 a--  24.62g 24.62g