Bug 837113

Summary:	Localize dynagroup expression error messages
Product:	[Other] RHQ Project	Reporter:	John Sanda <jsanda>
Component:	i18n	Assignee:	Nobody <nobody>
Status:	NEW ---	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	unspecified	CC:	hrupp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description John Sanda 2012-07-02 20:14:59 UTC

Description of problem:
This is directly related to bug 667896. With the changes for that bug, we no longer propagate an exception to the UI when a definition contains multiple expressions of the same type. Instead a more user-friendly error message is reported, like, "you cannot specify multiple configuration expressions." The error messages however are not localized. A little more work than usual will be involved to localize the error messages because they come directly from the server as opposed to being message strings that reside in the coregui module.

There will need to be some refactoring of ExpressionEvaluator to extract out some of the error detection and error reporting code into a module that is visible to coregui at runtime. Then both coregui and ExpressionEvaluator can reference the error codes which can be localized. Some of the necessary refactoring has already been done. The exception classes InvalidExpression and DuplicateExpressionTypeException have been move out of server/jar and into core/domain.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info: