Bug 837247

Can you please list all the other version that currently exist in /usr/share/rhev-hypervisor ?

To explain Simon's reason for his question in comment #2: The versions that will appear in the "RHEV-H ISO Name" drop-down are only available versions that their "major" part is the same as the "major" part of the current RHEV-H version.
E.g. if the RHEV-H Host current version is "6.3" and I have RHEV-H ISOs of versions 5.8, 5.9, 6.2, 6.3, 6.4 in "/usr/share/rhev-hypervisor", I will see in the drop down only versions that begin with "6", i.e., 6.2, 6.3, 6.4.

(In reply to comment #3)
> To explain Simon's reason for his question in comment #2: The versions that
> will appear in the "RHEV-H ISO Name" drop-down are only available versions
> that their "major" part is the same as the "major" part of the current
> RHEV-H version.
> E.g. if the RHEV-H Host current version is "6.3" and I have RHEV-H ISOs of
> versions 5.8, 5.9, 6.2, 6.3, 6.4 in "/usr/share/rhev-hypervisor", I will see
> in the drop down only versions that begin with "6", i.e., 6.2, 6.3, 6.4.

Why, exactly, are we suppressing the minor part of the version?  That's a fairly crucial bit of information.  IMO, we should be showing all versions that are available under /usr/share/rhev-hypervisor.  There may be cases where just the latest version of 6.3 is not the one that is desired, but there is no longer any way to select latest-1

(In reply to comment #4)
> (In reply to comment #3)
> > To explain Simon's reason for his question in comment #2: The versions that
> > will appear in the "RHEV-H ISO Name" drop-down are only available versions
> > that their "major" part is the same as the "major" part of the current
> > RHEV-H version.
> > E.g. if the RHEV-H Host current version is "6.3" and I have RHEV-H ISOs of
> > versions 5.8, 5.9, 6.2, 6.3, 6.4 in "/usr/share/rhev-hypervisor", I will see
> > in the drop down only versions that begin with "6", i.e., 6.2, 6.3, 6.4.
> 
> Why, exactly, are we suppressing the minor part of the version?  That's a
> fairly crucial bit of information.  IMO, we should be showing all versions
> that are available under /usr/share/rhev-hypervisor.  There may be cases
> where just the latest version of 6.3 is not the one that is desired, but
> there is no longer any way to select latest-1

i may be missing here, but einav comment was that the filter is based on the major version matching the version of the node to be upgraded (since upgrade isn't supported between major versions)?

(In reply to comment #7)

> 
> i may be missing here, but einav comment was that the filter is based on the
> major version matching the version of the node to be upgraded (since upgrade
> isn't supported between major versions)?

I misread the explanation.  My complaint is more in line with bug 835841.

(In reply to comment #2)
> Can you please list all the other version that currently exist in
> /usr/share/rhev-hypervisor ?

# ll /usr/share/rhev-hypervisor/
total 790428
-rw-r--r--. 1 root root 140509184 Jul  5 09:04 rhevh-6.1-20120607.0.iso
-rw-r--r--. 1 root root 132120576 Jul  5 09:04 rhevh-6.2-20111117.1.el6.iso
-rw-r--r--. 1 root root 180355072 Jul  5 09:05 rhevh-6.3-20120621.0.el6_3.iso
-rw-r--r--. 1 root root 180355072 Jul  3 02:56 rhevh-6.3-20120702.0.el6_3.iso
lrwxrwxrwx. 1 root root        57 Jul  3 10:58 rhevh-latest-6.iso -> /usr/share/rhev-hypervisor/rhevh-6.3-20120702.0.el6_3.iso
-rw-r--r--. 1 root root 176043624 Jul  3 10:57 rhev-hypervisor6-6.3-20120702.0.el6_3.noarch.rpm
lrwxrwxrwx. 1 root root        57 Jul  3 10:58 rhev-hypervisor6.iso -> /usr/share/rhev-hypervisor/rhevh-6.3-20120702.0.el6_3.iso
lrwxrwxrwx. 1 root root        57 Jul  3 10:58 rhev-hypervisor.iso -> /usr/share/rhev-hypervisor/rhevh-6.3-20120702.0.el6_3.iso
-rw-r--r--. 1 root root        21 Jul  3 03:01 version-6.3-20120702.0.el6_3.txt
lrwxrwxrwx. 1 root root        59 Jul  3 10:58 version.txt -> /usr/share/rhev-hypervisor/version-6.3-20120702.0.el6_3.txt

There are 3 versions(6.1, 6.2, 6.3) in /usr/share/rhev-hypervisor, but only the "6.3" shows in the upgrade drop-down list.
According comment 3, it should show as 6.1, 6.2, 6.3.

(In reply to comment #9)
> ...
> According comment 3, it should show as 6.1, 6.2, 6.3.

Indeed; however, I gave only a partial explanation: I am not sure about it (therefore, setting needinfo on masayag to verify), but I believe that only iso files that has a matching ".txt" file are being taken into consideration when building the list of available RHEV-H ISOs in the backend, and it seems here that there is only one ".txt" file, which is: version-6.3-20120702.0.el6_3.txt.

mike - since which rhev-h 6.x and 5.x do we have the .txt which were the base for this feature?
maybe we need to give a simple script to generate the .txt files for older versions of rhev-h?

(In reply to comment #10)
> (In reply to comment #9)
> > ...
> > According comment 3, it should show as 6.1, 6.2, 6.3.
> 
> Indeed; however, I gave only a partial explanation: I am not sure about it
> (therefore, setting needinfo on masayag to verify), but I believe that only
> iso files that has a matching ".txt" file are being taken into consideration
> when building the list of available RHEV-H ISOs in the backend, and it seems
> here that there is only one ".txt" file, which is:
> version-6.3-20120702.0.el6_3.txt.

The commit message of 93b5ed9c65384929c15a5fc1c0f5f563affb0568 (and the patch content) supports what you described:

    The patch modifies the way RHEV-H images were retrieved to the user:
    Start from rhevh 6.2 for beta-3, the installation of ovirt-rpm on engine
    server will add additional versions of iso files and a text file for
    each iso which contains the iso version, in the same folder
    (/usr/share/rhev-hypervisor/)

    The patch will retrieve the list of available isos by parsing the
    version files, resolving the iso file, validate its existence and its
    version (should be greater than 5.7, where the isos folder used to
    contain a single file in unsupported naming convention).

Therefore each iso file should have a compliant .txt file containing the image version. The creation of supported list is created according to the major version of the host os.

(In reply to comment #11)
> mike - since which rhev-h 6.x and 5.x do we have the .txt which were the
> base for this feature?
> maybe we need to give a simple script to generate the .txt files for older
> versions of rhev-h?

5.8 GA version added this version.txt file for each install.  Prior to that version, we did not support side-by-side installation.  

It may make sense to have some form of fallback in the case where version.txt is not available.  Users *could* just upload isos to that directory themselves.  With the plugin feature that is coming in the near future, there could be plain iso files there without corresponding version files.  Maybe list out file names for the iso's that don't have corresponding version.txt files?

iiuc, plan here is to provide a script to fix creation of these .txt files?

Created attachment 599696 [details]
A script to generate missing .txt files

Attaching a script which generates the missing version-xxx.txt files.

The way to use it is:
gentxt4iso rhevh-iso-folder [-l|--link]

where:
* rhevh-iso-folder is where the rpm puts the iso files
* otional -l or --link: generate for sym-links as well (avoid if possible).

Note that the script assumes a correct iso file name format, which is:
rhevh-RELEASE-VERSION.iso
Malformed file names will fail.

This is the output of the script on a setup which reproduces the BZ:
$ ./gentxt4iso /tmp/bz-837247
Processing file: /tmp/bz-837247/rhevh-6.1-20120607.0.iso
>>> Generating: version-6.1-20120607.0.txt
Processing file: /tmp/bz-837247/rhevh-6.2-20111117.1.el6.iso
>>> Generating: version-6.2-20111117.1.el6.txt
Processing file: /tmp/bz-837247/rhevh-6.3-20120621.0.el6_3.iso
>>> Generating: version-6.3-20120621.0.el6_3.txt
Processing file: /tmp/bz-837247/rhevh-6.3-20120702.0.el6_3.iso
    Skipping existing TXT file.
Processing file: /tmp/bz-837247/rhevh-latest-6.iso
    Skipping /tmp/bz-837247/rhevh-latest-6.iso symbolic link file.

In this case, the system behaves as expected.

In standard RHEV-H RPM installations, a matching .txt file is provided,
and the backend handles it properly. ISO file manipulation (cp / mv)
outside the official RPM install is unsupported.

Still, in order to assist users adjust, a script is given to generate
the missing .txt files. With this we conclude the resolution of this BZ.

Doron, 
Thank you for the script, but I would readdress Mike's question on comment 15.
Could you please explain the logic behind using the txt file for each ISO and how do we plan treat scenarios when txt file does not exit?

Doron, canceling the need info.
Talked to Simon.
I understand that if we want to support upgrades from RHEV-M, we need to trust the source (the iso file) we are going to use.

(In reply to comment #21)
> Doron, canceling the need info.
> Talked to Simon.
> I understand that if we want to support upgrades from RHEV-M, we need to
> trust the source (the iso file) we are going to use.

Marina,
the whole mechanism engine is using for rhev-h upgrades, is based
upon rhev-h methodology. Basically it means every iso comes with
its own version text file. So this is what the engine is looking
for.