Bug 838327
| Summary: | Review Request: spamassassin-iXhash2 - SpamAssassin plugin to lookup e-mail checksums in blacklists | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Robert Scheck <redhat-bugzilla> |
| Component: | Package Review | Assignee: | Kevin Fenzi <kevin> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | kevin, notting, package-review |
| Target Milestone: | --- | Flags: | kevin:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-31 16:59:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Robert Scheck
2012-07-08 12:41:02 UTC
I might be able to review in a few days... if no one beats me to it. ;) Look for a review here soon. OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (ASL 2.0) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream sha256sum: 8d51fe8661bf407433db6c0fa12e3c6c66a1cd626751f51b170990089dc966a8 iXhash2-2.05.tar.gz 8d51fe8661bf407433db6c0fa12e3c6c66a1cd626751f51b170990089dc966a8 iXhash2-2.05.tar.gz.orig See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Build seems to fail here: + perldoc iXhash2.pm /var/tmp/rpm-tmp.X9jg0p: line 43: perldoc: command not found error: Bad exit status from /var/tmp/rpm-tmp.X9jg0p (%install) Adding perl-Pod-Perldoc to BuildRequires seems to fix it. 2. rpmlint says: spamassassin-iXhash2.noarch: W: spelling-error Summary(en_US) lookup -> lockup, hookup, look up spamassassin-iXhash2.noarch: W: spelling-error Summary(en_US) checksums -> check sums, check-sums, checks spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US iXhash -> ix hash, ix-hash, hashish spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US async -> sync, a sync spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US lookups -> lockups, hookups, look ups spamassassin-iXhash2.noarch: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks spamassassin-iXhash2.src: W: spelling-error Summary(en_US) lookup -> lockup, hookup, look up spamassassin-iXhash2.src: W: spelling-error Summary(en_US) checksums -> check sums, check-sums, checks spamassassin-iXhash2.src: W: spelling-error %description -l en_US iXhash -> ix hash, ix-hash, hashish spamassassin-iXhash2.src: W: spelling-error %description -l en_US async -> sync, a sync spamassassin-iXhash2.src: W: spelling-error %description -l en_US lookups -> lockups, hookups, look ups spamassassin-iXhash2.src: W: spelling-error %description -l en_US checksums -> check sums, check-sums, checks All can be ignored. spamassassin-iXhash2.noarch: W: self-obsoletion spamassassin-iXhash < 1.5.6-1 obsoletes spamassassin-iXhash = 1.5.5-2 Is there a reason for this? spamassassin-iXhash2.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 13, tab: line 1) Cosmetic, clean up if you like. (In reply to comment #3) > Adding perl-Pod-Perldoc to BuildRequires seems to fix it. Whoops, forgotten. Of course. > spamassassin-iXhash2.noarch: W: self-obsoletion spamassassin-iXhash < > 1.5.6-1 obsoletes spamassassin-iXhash = 1.5.5-2 > > Is there a reason for this? Args. No, should be both the same version. > spamassassin-iXhash2.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line > 13, tab: line 1) Not intended... I'm using %{_bindir}/perldoc rather perl-Pod-Perldoc due to different packages
over the different Fedora and EPEL versions.
Spec URL: http://labs.linuxnetz.de/bugzilla/spamassassin-iXhash2.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/spamassassin-iXhash2-2.05-2.src.rpm
ok, looks fine to me. I see no more blockers so this package is APPROVED. Kevin, thank you very much for the review. New Package SCM Request ======================= Package Name: spamassassin-iXhash2 Short Description: SpamAssassin plugin to lookup e-mail checksums in blacklists Owners: robert Branches: f16 f17 el5 el6 InitialCC: Git done (by process-git-requests). spamassassin-iXhash2-2.05-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/spamassassin-iXhash2-2.05-2.fc17 spamassassin-iXhash2-2.05-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/spamassassin-iXhash2-2.05-2.fc16 spamassassin-iXhash2-2.05-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/spamassassin-iXhash2-2.05-2.el6 spamassassin-iXhash2-2.05-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/spamassassin-iXhash2-2.05-2.el5 spamassassin-iXhash2-2.05-2.el5 has been pushed to the Fedora EPEL 5 testing repository. spamassassin-iXhash2-2.05-2.el5 has been pushed to the Fedora EPEL 5 stable repository. spamassassin-iXhash2-2.05-2.el6 has been pushed to the Fedora EPEL 6 stable repository. spamassassin-iXhash2-2.05-2.fc16 has been pushed to the Fedora 16 stable repository. spamassassin-iXhash2-2.05-2.fc17 has been pushed to the Fedora 17 stable repository. |