Bug 838621
| Summary: | Review Request: perl-ServiceNow-API - ServiceNow API for accessing the Service-now platform | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marek Mahut <mmahut> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, notting, package-review, psabata |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-16 12:02:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marek Mahut
2012-07-09 15:48:24 UTC
* Correctly named
* Packing latest version
* License is correctly specified and a free license
* SPEC file clean and legible
- Distribution link broken!
CPAN one does not exist: http://search.cpan.org/dist/ServiceNow-API/
Did you mean this? http://wiki.servicenow.com/index.php?title=Perl_API
- Unpacking fails, since the zifile contains a "__MACOSX/" toplevel directory:
+ /usr/bin/unzip -qq /home/lkundrak/rpmbuild/SOURCES/ServiceNow-Perl-API.zip
replace __MACOSX/ServiceNow-1.01/._.DS_Store? [y]es, [n]o, [A]ll, [N]one, [r]ename:
You may want to use the following %prep instead to add a level in hierarchy
%setup -q -c -n %{name}-%{version}
%setup -D -T -q -n %{name}-%{version}/ServiceNow-%{version}
- You're missing a BR for testing: BuildRequires: perl(Test::Pod::Coverage)
- POD tests fail if coverage test module is installed:
t/pod-coverage.t .. 1/19
# Failed test 'Pod coverage on ServiceNow'
# at /usr/share/perl5/Test/Pod/Coverage.pm line 126.
# Coverage for ServiceNow is 96.4%, with 1 naked subroutine:
# createNotification
- Empty %doc
You may want to include README, etc.
- Rebuild for 5.16 in changelog?
You may want to remove that.
Thank you for your comments. New SRPM http://mmahut.fedorapeople.org/reviews/perl-ServiceNow-API/perl-ServiceNow-API-1.01-2.el6.src.rpm Looks wonderful, Marek. This package is a pure act of beauty. Even builds cleanly in mock! May God bless you and your family! http://koji.fedoraproject.org/koji/taskinfo?taskID=4230253 http://koji.fedoraproject.org/koji/taskinfo?taskID=4230247 This is happily APPROVED by me! Thank you Lubomir. New Package SCM Request ======================= Package Name: perl-ServiceNow-API Short Description: ServiceNow API for accessing the Service-now platform Owners: mmahut Branches: f16 f17 el6 Git done (by process-git-requests). Thank you both. perl-ServiceNow-API-1.01-2.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/perl-ServiceNow-API-1.01-2.fc17 perl-ServiceNow-API-1.01-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-ServiceNow-API-1.01-2.fc16 perl-ServiceNow-API-1.01-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-ServiceNow-API-1.01-2.el6 perl-ServiceNow-API-1.01-2.fc17 has been pushed to the Fedora 17 stable repository. perl-ServiceNow-API-1.01-2.fc16 has been pushed to the Fedora 16 stable repository. perl-ServiceNow-API-1.01-2.el6 has been pushed to the Fedora EPEL 6 stable repository. Package Change Request ====================== Package Name: perl-ServiceNow-API Branches: f16 f17 f18 el6 Owners: InitialCC: perl-sig Please add perl-sig user with watch* permissions only to all Fedora branches. Misformatted request. (In reply to comment #14) > Misformatted request. Could you be more specific, please? Maybe I'm missing some obvious typo... |