Bug 839241

Summary:	cman config reload can leak memory and does not propagate all info correctly
Product:	Red Hat Enterprise Linux 6	Reporter:	Fabio Massimo Di Nitto <fdinitto>
Component:	cluster	Assignee:	Fabio Massimo Di Nitto <fdinitto>
Status:	CLOSED ERRATA	QA Contact:	Cluster QE <mspqa-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.4	CC:	ccaulfie, cluster-maint, lhh, mjuricek, rpeterso, teigland
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cluster-3.0.12.1-33.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-02-21 07:42:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabio Massimo Di Nitto 2012-07-11 10:50:29 UTC

3 values that are generated at startup time (cluster_id, two_node, nodename) are not correctly re-instated in the objdb on config reload.

start cluster
corosync-objctl |grep cman

 cluster.cman.cluster_id=25573
 cluster.cman.nodename=fedora16-node1

increase version in cluster.conf, reload

the same command will show no output.

In the reload path, via code review, there is also a corner case where we can leak a tiny amount of memory if config reload fails. This is not easy to trigger or test. devel review required for the fix.

After patching, corosync-objctl will show the items as expected.

Comment 1 Fabio Massimo Di Nitto 2012-07-11 10:51:29 UTC

http://git.fedorahosted.org/git/?p=cluster.git;a=commitdiff;h=88ab6a7b1e4da3802f64addc3d6f234e5cf82760

unit test in comment #1. Patch tested also by community (see cluster-devel).

Comment 8 errata-xmlrpc 2013-02-21 07:42:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2013-0287.html