Bug 839301
| Summary: | Package Rename Review Request: python-django-evolution - Schema evolution for Django | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Stephen Gallagher <sgallagh> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, mrunge, notting, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-03 10:50:32 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 736776 | ||
|
Description
Stephen Gallagher
2012-07-11 13:50:12 UTC
Scratch-built in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4233568 I'll take this for a review. - According to [1], the obsoletes shouldn't use macros, but rather hardcode the version from where you renamed the package. E.g. you should have "Obsoletes: django-evolution < 0.6.7-2". - "%defattr(-,root,root,-)" is not needed in the %files section, unless you want to build for EPEL 5 (which presumably you don't). Same applies for the BuildRoot tag, %clean section and "rm -rf $RPM_BUILD_ROOT". - You should delete the bundled egg-info directory in the %prep section (rm -rf django_evolution.egg-info), so that it gets regenerated during %build. These are not serious issues, so once you fix them, I will approve the package. [1] http://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages New version with corrections: Spec URL: http://sgallagh.fedorapeople.org/packagereview/python-django-evolution/python-django-evolution.spec SRPM URL: http://sgallagh.fedorapeople.org/packagereview/python-django-evolution/python-django-evolution-0.6.7-3.fc18.src.rpm Note, this does not scratch-build in Rawhide at the moment due to a bad openssl build currently in the BuildRoot. One more fix: You correctly hardcoded the obsoleted version, but the version you Provide should use the macros. E.g, you should have:
Provides: django-evolution = %{name}-%{release}
Obsoletes: django-evolution < 0.6.7-3
I don't have any more comments. Please fix this one before importing and don't forget to properly deprecate django-evolution from rawhide.
Thanks!
This package is APPROVED.
New Package SCM Request ======================= Package Name: python-django-evolution Short Description: Schema evolution for Django Owners: sgallagh Branches: InitialCC: sgallagh Git done (by process-git-requests). Package Change Request ====================== Package Name: python-django-evolution New Branches: el6 Owners: sgallagh, diegobz InitialCC: Migrating from django-evolution to python-django-evolution on EL6 to make maintenance simpler. Git done (by process-git-requests). |