Bug 839516

Summary: [RHEVM] [backend] [Setup Host Networks] there is no indication in GUI on wrong input for custom bond mode options
Product: Red Hat Enterprise Virtualization Manager Reporter: Martin Pavlik <mpavlik>
Component: ovirt-engineAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 3.1.0CC: dyasny, gklein, iheim, lpeer, Rhev-m-bugs, sgrinber, yeylon, ykaul
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: network
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-12 08:05:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Network RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
vdsm.log + engine.log
none
screenshot 1 none

Description Martin Pavlik 2012-07-12 07:54:21 UTC 
Created attachment 597725 [details]
vdsm.log + engine.log

Description of problem:
If user sets up a bond with bonding mode=custom, and puts in real nonsense which cannot be parsed (e.g. 123456789)(see screenshot 1), there is correct ERROR message generated in logs, but no indication in GUI. User should be notified on what is wrong, either by message in events or by window with error message.

Version-Release number of selected component (if applicable):
oVirt Engine Version: 3.1.0-5.el6ev 
vdsm-4.9.6-17.0.el6.x86_64

How reproducible:
100%

Steps to Reproduce:
Need host with 3 NICs, 1 logical network defined
1. Hosts-> your host -> Network Interfaces -> Setup host networks 
   a) put two free interfaces together to create bond
   b) bonding mode = custom
   c) fill in Custom mode=123456789 -> click OK
   d) attach logical network to bond
   e) click OK
  
Actual results:
after clicking OK, Setup Network dialog just reappears with no GUI indication what is wrong

Expected results:
User should be notified on what is wrong, either by message in events or by window with error message.

Additional info:
Thread-47151::DEBUG::2012-07-12 09:43:30,568::BindingXMLRPC::870::vds::(wrapper) return setupNetworks with {'status': {'message': "Error parsing bonding options: '123456789'", 'code': 25}}
Comment 1 Martin Pavlik 2012-07-12 07:54:44 UTC 
Created attachment 597727 [details]
screenshot 1
Comment 2 Yaniv Kaul 2012-07-12 08:05:28 UTC 
We don't perform any verification on custom entries - we can't guess what is valid or what isn't (I guess we can assume it has to be ASCII, but it's not worth the effort).
However, I am surprised how VDSM had an error for it. Need to see why
Comment 3 Simon Grinberg 2012-07-12 08:46:06 UTC 
(In reply to comment #2)
> We don't perform any verification on custom entries - we can't guess what is
> valid or what isn't (I guess we can assume it has to be ASCII, but it's not
> worth the effort).
> However, I am surprised how VDSM had an error for it. Need to see why

Unless it's known parameters as mode?
Regardless of the above which is a different issue (IE, should VDSM verify custom properties at all) If VDSM fails setting the configuration the dialog should not just re-appear.

If possible mark the failing value, else have a message at the top indicating that setting the current configuration has failed, please look at the events (and events should indicate the failure) and the log file for more details