| Summary: | Review Request: rubygem-awesome_print - Pretty print Ruby objects with proper indentation and colors | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Maros Zatko <mzatko> |
| Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mfojtik, mmorsi, notting, package-review, vondruch |
| Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-05-06 11:54:51 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Maros Zatko
2012-07-12 13:42:49 UTC
Review: - The 'License: GPLv2+ or Ruby' seems to be wrong, according to GitHub page it should be MIT - Consider using %gem_name macro here: URL: http://github.com/michaeldv/awesome_print - Move the 'spec' files into -doc subpackage, since they are not needed for the main gem funcionality. %{gem_instdir}/spec/colors_spec.rb .... - Consider removing these files: %{gem_instdir}/.gitignore %{gem_instdir}/.yardoc/checksums %{gem_instdir}/.yardoc/objects/root.dat %{gem_instdir}/.yardoc/proxy_types %{gem_instdir}/Gemfile.lock - Move LICENSE into main %files section - Please run the 'spec' files in the %check section Thanks for your review, I've updated spec, so Spec URL: http://v3.sk/~hexo/rpm/awesome_print.spec SRPM URL: http://v3.sk/~hexo/rpm/rubygem-awesome_print-1.0.2-2.fc17.src.rpm Description: Great Ruby dubugging companion: pretty print Ruby objects to visualize their structure. Supports custom object formatting via plugins Fedora Account System Username: mzatko Maros, there are still some updates needed to this package.
As Michal mentioned please move the %{gem_instdir}/spec/ dir into the 'doc' files list.
You should not be excluding the Gemfile (the Gemfile.lock is ok), and consider rm'ing the files in one of the previous sections instead of marking them as %exclude (I believe both are acceptable though the former is more common / cleaner).
Lastly unless there is a reason not too (if so list it here) please add a %check section where you invoke the spec suite (manually so as not to pull in rake).
Thanks.
it's here, again Spec URL: http://v3.sk/~hexo/rpm/rubygem-awesome_print.spec SRPM URL: http://v3.sk/~hexo/rpm/rubygem-awesome_print-1.0.2-5.fc17.src.rpmDescription: Great Ruby dubugging companion: pretty print Ruby objects to visualize their structure. Supports custom object formatting via plugins Fedora Account System Username: mzatko Looks good, APPROVED New Package SCM Request ======================= Package Name: rubygem-awesome_print Short Description: Pretty print Ruby objects with proper indentation and colors Owners: mzatko Branches: f17 f18 InitialCC: Git done (by process-git-requests). This is already available in F19/Rawhide, so this could be probably closed. |