Bug 840037
| Summary: | Review Request:rubygem-openshift-origin-node - Application container runtime for OpenShift | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Brenton Leanhardt <bleanhar> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dwmw2, gwync, misc, notting, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-17 22:47:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 839064 | ||
| Bug Blocks: | 842006, 842891, 844439, 845314, 845319 | ||
|
Description
Brenton Leanhardt
2012-07-13 14:00:16 UTC
Here's the rpmlint output: http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/rubygem-stickshift-node.rpmlint.out I have updated this package with feedback from two other reviews. The latest artifacts can be found here: http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/0.14.1-2.git.98.1915eff/rubygem-stickshift-node.spec http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/0.14.1-2.git.98.1915eff/rubygem-stickshift-node-0.14.1-2.git.98.1915eff.rpmlint.out http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/0.14.1-2.git.98.1915eff/rubygem-stickshift-node-0.14.1-2.git.98.1915eff.fc17.noarch.rpm A description of the changes can be found in the changelog. I incorrectly linked to the binary RPM in my last comment. Here's the SRPM: http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/0.14.1-2.git.98.1915eff/rubygem-stickshift-node-0.14.1-2.git.98.1915eff.fc17.src.rpm Here's the updated artifacts. I changed the Source0 line to use the gem and updated the %prep, %build and %install stanzas accordingly. http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/201207201705/rubygem-stickshift-node.spec http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/201207201705/rubygem-stickshift-node.rpmlint.out http://brenton.fedorapeople.org/package_reviews/rubygem-stickshift-node/201207201705/rubygem-stickshift-node-0.14.2-1.fc18.src.rpm Here are the latest fixes: fedora-reivew: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208061658/rubygem-openshift-origin-node-review.txt SRPM: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208061658/rubygem-openshift-origin-node-0.14.6-2.fc18.src.rpm Spec: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208061658/rubygem-openshift-origin-node.spec A few items here: * You've still got one %define, please replace it with %global. * You're packaging an Apache HTTPD configuration file. Does this package need to have an explicit Requires: httpd ? * You should avoid using macros in comments or changelog entries. Just use %%foo instead of %foo, that will keep rpm from trying to eval them and will silence rpmlint. Everything else looks very clean and in keeping with the Guidelines. If you make those changes, I will finish off a review. (I note that you're looking for a sponsor, but I believe someone was willing to sponsor you as soon as 839064 is done). Oh, and also: rubygem-openshift-origin-node.noarch: E: non-executable-script /usr/share/gems/gems/openshift-origin-node-0.14.6/test/unit/version_test.rb 0644L /usr/bin/ruby rubygem-openshift-origin-node.noarch: E: non-executable-script /usr/share/gems/gems/openshift-origin-node-0.14.6/lib/stickshift-node/model/node.rb 0644L /usr/bin/env rubygem-openshift-origin-node.noarch: E: non-executable-script /usr/share/gems/gems/openshift-origin-node-0.14.6/test/unit/unix_user_test.rb 0644L /usr/bin/ruby rubygem-openshift-origin-node.noarch: E: script-without-shebang /usr/share/gems/gems/openshift-origin-node-0.14.6/lib/stickshift-node/model/unix_user.rb I think that should be as simple to resolve as running chmod +x on the "non-executable-script" files during %install, and chmod -x on the "script-without-shebang" file. fedora-review: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208071302/rubygem-openshift-origin-node-review.txt SRPM: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208071302/rubygem-openshift-origin-node-0.14.6-3.fc18.src.rpm Spec: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208071302/rubygem-openshift-origin-node.spec I linked to the pull request for the upstream fixes. I added a patch that makes the gemspec homepage match the spec homepage. SRPM: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208101436/rubygem-openshift-origin-node-0.14.6-4.fc18.src.rpm Spec: http://brenton.fedorapeople.org/package_reviews/rubygem-openshift-origin-node/201208101436/rubygem-openshift-origin-node.spec = REVIEW = - rpmlint checks return: rubygem-openshift-origin-node.src: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment rubygem-openshift-origin-node.src: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed rubygem-openshift-origin-node.src: W: spelling-error %description -l en_US cgroups -> groups, c groups rubygem-openshift-origin-node.src:152: W: macro-in-%changelog %post rubygem-openshift-origin-node.src:152: W: macro-in-%changelog %preun rubygem-openshift-origin-node.noarch: W: spelling-error Summary(en_US) runtime -> run time, run-time, rudiment rubygem-openshift-origin-node.noarch: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed rubygem-openshift-origin-node.noarch: W: spelling-error %description -l en_US cgroups -> groups, c groups rubygem-openshift-origin-node.noarch: W: hidden-file-or-dir /var/lib/stickshift/.httpd.d rubygem-openshift-origin-node.noarch: W: hidden-file-or-dir /var/lib/stickshift/.httpd.d rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-authorized-ssh-key-add rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-cartridge-list rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary sssh rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-broker-auth-key-add rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-connector-execute rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-app-destroy rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-env-var-remove rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-app-create rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-get-quota rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-env-var-add rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-cartridge-info rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-set-quota rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-trap-user.ruby19 rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-broker-auth-key-remove rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-authorized-ssh-key-remove rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-trap-user rubygem-openshift-origin-node.noarch: W: no-manual-page-for-binary ss-app-state-show 2 packages and 0 specfiles checked; 0 errors, 27 warnings. All safe to ignore, but you really should %% comment out those macro references in the changelog. - package meets naming guidelines - package meets packaging guidelines (Ruby) - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (9ee5ce05a74e0b071a506a31a92e393ba74e359449785c42935e724a7346cf75) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. New Package SCM Request ======================= Package Name: rubygem-openshift-origin-node Short Description: Application container runtime for OpenShift Owners: brenton tdawson maxamillion Branches: f17 f18 InitialCC: Don't set SCM flag if review flag not set to + by reviewer. Thanks! Tom, seems you forgot to set fedora-review flags to + Is Brenton sponsored? I'll flip the flag when the FE-NEEDSPONSOR blocker is gone. According to our irc based kryptonian overloard, it seems so : misc> .fasinfo brenton zodbot> misc: User: brenton, Name: Brenton Leanhardt, email: bleanhar, Creation: 2008-06-06, IRC Nick: bleanhar, Timezone: US/Eastern, Locale: en, GPG key ID: B1EA09B2, Status: active zodbot> misc: Approved Groups: fedorabugs packager cla_done cla_fpca cla_fedora @gitgenome @gitpublican-genome @gitplublican-genome ( ie, in the packager group should be enough, I guess ) Mmkay. Flipping the review flag. New Package SCM Request ======================= Package Name: rubygem-openshift-origin-node Short Description: Application container runtime for OpenShift Owners: brenton tdawson maxamillion Branches: f17 f18 InitialCC: Git done (by process-git-requests). rubygem-openshift-origin-node-0.14.6-5.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-node-0.14.6-5.fc18 rubygem-openshift-origin-node-0.14.6-5.fc18 has been pushed to the Fedora 18 testing repository. rubygem-openshift-origin-node-0.14.6-5.fc18 has been pushed to the Fedora 18 stable repository. |