Bug 840878

Summary:	Review Request: liberation-narrow-fonts - Sans-serif Narrow fonts to replace commonly used Arial Narrow
Product:	[Fedora] Fedora	Reporter:	Pravin Satpute <psatpute>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	17	CC:	notting, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-07-27 10:59:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Pravin Satpute 2012-07-17 13:33:56 UTC

Scratch build : http://koji.fedoraproject.org/koji/taskinfo?taskID=4246404

SRPM Url : http://pravins.fedorapeople.org/liberation-narrow-fonts-1.07.2-7.fc17.src.rpm
SPEC Url : http://pravins.fedorapeople.org/liberation-narrow-fonts.spec


Additional Information:
- liberation-fonts-2.00.0 upstream version is licensed under OFL. 
- Due to licensing problem of Liberation Sans Narrow cant keep this package together with liberation-fonts.
- This is one of the existing subpackage of package liberation-fonts-1.07.2-6.
- In future if licensing problem of Liberation Sans Narrow gets resolved then we can orphan this package and can provide it as a subpackage of liberation-fonts.

Comment 1 Parag AN(पराग) 2012-07-20 09:33:33 UTC

suggestions:
1) Use %global instead of %define.
2) cp commands should preserve timestamp
3) use actual commands for {_ln_s}

Comment 2 Pravin Satpute 2012-07-20 12:15:54 UTC

hmm, lots of changes happened after liberation-fonts last review. I will do suggested changes in liberation-fonts packages as wellupdated spec and srpm.

Wondering still liberation fonts does not have .conf file, task pending on me though

SRPM Url : http://pravins.fedorapeople.org/liberation-narrow-fonts-1.07.2-8.fc17.src.rpm
SPEC Url : http://pravins.fedorapeople.org/liberation-narrow-fonts.spec

Comment 3 Parag AN(पराग) 2012-07-24 10:42:08 UTC

Review:-

+ Koji f18 scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4325263

+ rpmlint on rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ source verified with upstream as (sha1sum)
4db1abfdb6e41bdc9a461fc7dfecf996ff1d66e6  liberation-fonts-1.07.2.tar.gz
4db1abfdb6e41bdc9a461fc7dfecf996ff1d66e6  ../SOURCES/liberation-fonts-1.07.2.tar.gz

+ License is same as old package license and valid.

APPROVED.

You need to import this package and new update of liberation-fonts in same rawhide update.

Comment 4 Pravin Satpute 2012-07-25 08:42:27 UTC

Thanks Parag for review.

New Package SCM Request
=======================
Package Name: liberation-narrow-fonts
Short Description: Sans-serif Narrow fonts to replace commonly used Arial Narrow 
Owners: pravins
Branches: 
InitialCC: i18n-team

Comment 5 Gwyn Ciesla 2012-07-25 09:52:19 UTC

Git done (by process-git-requests).

Comment 6 Pravin Satpute 2012-07-27 10:59:01 UTC

Thanks Jon for git. 
Built this for rawhide.