Bug 841089

Summary: Review Request: rubygem-sprockets - Rack-based asset packaging system
Product: [Fedora] Fedora Reporter: Bohuslav "Slavek" Kabrda <bkabrda>
Component: Package ReviewAssignee: Vít Ondruch <vondruch>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, package-review, vondruch
Target Milestone: ---Flags: vondruch: fedora‑review+
limburgher: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-03 06:48:18 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:

Description Bohuslav "Slavek" Kabrda 2012-07-18 02:40:45 EDT
Spec URL: http://bkabrda.fedorapeople.org/pkgs/sprockets/rubygem-sprockets.spec
SRPM URL: http://bkabrda.fedorapeople.org/pkgs/sprockets/rubygem-sprockets-2.4.5-1.fc17.src.rpm
Description:
Sprockets is a Rack-based asset packaging system that concatenates and serves JavaScript, CoffeeScript, CSS, LESS, Sass, and SCSS.
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4247638
Fedora Account System Username: bkabrda
Comment 1 Vít Ondruch 2012-07-18 03:59:26 EDT
I'll take it for a review.
Comment 2 Vít Ondruch 2012-07-18 04:38:25 EDT
* Name of test suite archive
  - Although this is a minor nit, I would appreciate if you could adjust the
    Source1 name to %{gem_name}-%{version}-tests.tgz at least. That would be
    more aligned with the packaging guidelines example [1] and other Rails
    packages that already uses this approach.

Please consider fixing this minor nit. Otherwise, the package looks good => APPROVED



[1] https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package
Comment 3 Bohuslav "Slavek" Kabrda 2012-07-18 04:41:29 EDT
Yes, I will do that. Thanks for the review!


New Package SCM Request
=======================
Package Name: rubygem-sprockets
Short Description: Rack-based asset packaging system
Owners: bkabrda
Branches: 
InitialCC:
Comment 4 Jon Ciesla 2012-07-19 08:37:38 EDT
Git done (by process-git-requests).