Bug 841249

Summary: __pmDecodeText heap overflow
Product: [Fedora] Fedora Reporter: Florian Weimer <fweimer>
Component: pcpAssignee: Ken McDonell <kenj>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: kenj, mgoodwin, nathans, security-response-team
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcp-3.6.5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-20 00:00:20 EDT Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Bug Depends On:    
Bug Blocks: 840765, 841698    
Attachments:
Description Flags
Resolve issues in decoding PCP text PDUs none

Description Florian Weimer 2012-07-18 09:54:14 EDT
This is very similar to the __pmDecodeInstanceReq overflow (bug 841240).  buflen needs to be checked against the PDU size, and negative values need to be rejected.

This is not directly exposed through pmcd.
Comment 1 Mark Goodwin 2012-07-20 19:30:29 EDT
Ken requested assignment, thanks.
Comment 2 Nathan Scott 2012-07-27 02:38:22 EDT
Created attachment 600704 [details]
Resolve issues in decoding PCP text PDUs
Comment 3 Florian Weimer 2012-07-27 10:56:28 EDT
(In reply to comment #2)
> Created attachment 600704 [details]
> Resolve issues in decoding PCP text PDUs

This looks okay, with the same caveat as in bug 841240.
Comment 4 Huzaifa S. Sidhpurwala 2012-08-15 23:56:21 EDT
Upstream patch:

http://oss.sgi.com/cgi-bin/gitweb.cgi?p=pcp/pcp.git;a=commit;h=9f4e392c97ce42744ec73f82268ce6c815fdca0e

This issue has been addressed in pcp-3.6.5