Bug 841483
| Summary: | Review Request: kde-plasma-mail-checker - Plasmoid checking for new messages | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fl@sh <alex.mail.1534> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | alpha, gregor, kevin, lemenkov, micah.roth, nlminhtl, package-review, rdieter, vascom2 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-11-28 13:21:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 656997 | ||
|
Description
Fl@sh
2012-07-19 06:35:57 UTC
Hi, Fl@sh.
1. Remove BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
2. Remove %defattr(-,root,root) in %files section.
3. Use %_kde4_appsdir instead of %{_datadir}/kde4/apps
Also remove string %dir %{_datadir}/kde4/apps/plasma/plasmoids/%{name}
and remove "/*" at the end of previous string.
4. Remove %clean section.
5. Remove dot from the end os Summary.
6. Should add some documentation and license file
New: Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/4790/4264790/kde-plasma-mail-checker-1.7.31-1.fc17.src.rpm In Comment #1.3 : for Fedora koji not corrected (i`m make two attempt); the source url is not accessible. Tarball uploaded to git. Check it. New successfull build: Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/3051/4283051/kde-plasma-mail-checker-1.7.34-1.fc17.src.rpm looks quite good, but you should use %_kde4_appsdir in %files I have tried the %{_kde4_appsdir} in %files, but koji does not build the package.
Example: http://kojipkgs.fedoraproject.org//work/tasks/4401/4304401/build.log
fyi, The %{_kde4_*} macros are defined in /etc/rpm/macros.kde4 owned by kde-settings pkg, so add:
BuildRequires: kde-settings
And, no need to require PyQt4 or python (PyKDE4 already pulls in both PyQt4 and python implicitly)
I'd venture you don't need
BuildRequires: qt-devel
either, as far as I can tell the Makefile simply installs files, and doesn't actually build anything (or if I'm missing something, please do document why this is needed).
Thanks! I`m do the comment in spec about qt-devel build require. New : Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/2757/4322757/kde-plasma-mail-checker-1.7.35-1.fc17.src.rpm Please use: BuildRequires: qt4-devel instead of: BuildRequires: qt-devel The virtual Provides works independently of what version of Qt is the default. (Qt 5 is coming soon.) > fyi, The %{_kde4_*} macros are defined in /etc/rpm/macros.kde4 owned by > kde-settings pkg It's actually owned by kde-filesystem… > so add: > BuildRequires: kde-settings … so this should be: BuildRequires: kde-filesystem Ok, ok... (Well, torture is it to "cook the plasma" *smile*). New : Spec: https://raw.github.com/F1ash/plasmaMailChecker/simple/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/4234/4324234/kde-plasma-mail-checker-1.7.35-2.fc17.src.rpm Unblocking FE-NEEDSPONSOR - I've just sponsored Fl@sh. Someone wants to complete the review? Since Fl@sh is already sponsored, I am taking this review. New successfull build: Spec: https://raw.github.com/F1ash/plasmaMailChecker/10b7be10db07900861717727cd3a3459bef0caed/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/2718/4552718/kde-plasma-mail-checker-1.7.41-1.fc17.src.rpm New successfull build: Spec: https://raw.github.com/F1ash/plasmaMailChecker/18f665a433d68a4796ac84846cdc426dbbc698ba/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/7263/4647263/kde-plasma-mail-checker-1.8.47-1.fc18.src.rpm use desktop-file-validate (from desktop-file-utils package) for validating desktop files that is not applicable in this case Minh Ngo fyi, http://lists.fedoraproject.org/pipermail/kde/2012-August/011826.html (but this not displayed in instructions). Changed git-repo name: https://github.com/F1ash/kde-plasma-mail-checker SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec NB: Working on a new version. New version, fresh build: http://kojipkgs.fedoraproject.org//work/tasks/2494/5022494/kde-plasma-mail-checker-1.11.52-1.fc18.src.rpm New version, fresh build: http://kojipkgs.fedoraproject.org//work/tasks/9589/5199589/kde-plasma-mail-checker-1.12.55-1.fc18.src.rpm SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec SRPM link non functional. Aleksandra, please set the fedora-review flag to ? , if you intend to continue formally reviewing this, thanks. Repeat build: http://kojipkgs.fedoraproject.org//work/tasks/7981/5277981/kde-plasma-mail-checker-1.12.55-1.fc18.src.rpm New build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5444444 SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/4445/5444445/kde-plasma-mail-checker-1.15.60-1.fc18.src.rpm New build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5566546 SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/simple/kde-plasma-mail-checker.spec SRPM: http://kojipkgs.fedoraproject.org//work/tasks/6547/5566547/kde-plasma-mail-checker-1.15.62-1.fc19.src.rpm The Summary should be "Plasmoid checking for new messages", the %description should be "Plasmoid periodically checking for new messages in configured accounts.". Thanks) SPEC: https://raw.github.com/F1ash/kde-plasma-mail-checker/1.15.63/kde-plasma-mail-checker.spec SRPM: http://f1ash.fedorapeople.org/kde-plasma-mail-checker/kde-plasma-mail-checker-1.15.63-2.fc19.src.rpm resetting reviewer, lack of feedback. |