Bug 841684

Summary: Need Update for the "service jon-agent" Usage prompt
Product: [JBoss] JBoss Operations Network Reporter: Zhengping Jin <zjin>
Component: AgentAssignee: Stefan Negrea <snegrea>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: high    
Version: JON 3.1.0CC: fbrychta, jsanda
Target Milestone: CR01   
Target Release: JON 3.1.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-11 10:58:04 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 837381    

Description Zhengping Jin 2012-07-19 21:02:22 UTC
Description of problem:
missing "config" option in the "service jon-agent" Usage prompt

Version-Release number of selected component (if applicable): 3.1.0


How reproducible: 100%


Steps to Reproduce:
1. install agent
2. run "service agent"
  
Actual results:
Usage: /usr/share/jboss-on-3.1.0.GA/agent/bin/rhq-agent-wrapper.sh { start | stop | kill | restart | status }

Expected results:
Usage: /usr/share/jboss-on-3.1.0.GA/agent/bin/rhq-agent-wrapper.sh { config | start | stop | kill | restart | status }


Additional info:

Comment 1 Charles Crouch 2012-07-20 17:36:28 UTC
This covers changing the usage help text only, to include the new option

Comment 2 John Mazzitelli 2012-08-03 15:14:11 UTC
I need replication procedures to fill out the "install agent" step. What is being done to think that "config" is a valid option?

Looking at that script itself, it does not accept "config" as a valid option:

$ ./rhq-agent-wrapper.sh config
Usage: ./rhq-agent-wrapper.sh { start | stop | kill | restart | status }

It isn't accepted (which you can see when it behaves the same when giving it a bad option):

$ ./rhq-agent-wrapper.sh blah
Usage: ./rhq-agent-wrapper.sh { start | stop | kill | restart | status }

Comment 3 Zhengping Jin 2012-08-03 15:26:17 UTC
expect results suggestion as:

Usage: service jon-agent { config | start | stop | kill | restart | status }

Comment 4 Stefan Negrea 2012-08-20 20:29:56 UTC
Moved the config option for the rpm init script to the product wrapper script. 


release/jon3.1.x branch commit:
http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?h=release/jon3.1.x&id=97178358504e3807d4f8ce65fbd7a56b3bb24048

Comment 6 John Sanda 2012-08-30 01:46:47 UTC
The CR1 build is available at
https://brewweb.devel.redhat.com/buildinfo?buildID=231258. Moving to ON_QA.

Comment 7 Mike Foley 2012-08-31 19:03:01 UTC
[root@foleymonsterbox1 bin]# ./rhq-agent-wrapper.sh config
Usage: ./rhq-agent-wrapper.sh { start | stop | kill | restart | status }
[root@foleymonsterbox1 bin]#

Comment 8 Stefan Negrea 2012-09-21 18:19:31 UTC
Please repeat the test and compare the result with the result in comment #3 and the code commit from comment #4. 

The output shown in comment #7 is not valid and the agent RPM was not used for testing. Please use the agent RPM install in conjunction jon-agent service commands.

Comment 9 Filip Brychta 2012-09-24 12:33:54 UTC
Verified on 3.1.1.GA for both the agent installed from rpm (using service jon-agent config) and from zip (using ./rhq-agent-wrapper.sh config)