Bug 842107

fixed UTF-8 character encoding issue in NEWS file


http://snavin.fedorapeople.org/packages/sugar-america/sugar-america.spec

http://snavin.fedorapeople.org/packages/sugar-america/sugar-america-5-2.fc17.src.rpm

Unofficial review.

It duplicate https://bugzilla.redhat.com/show_bug.cgi?id=838252 ?

1. sugar-america.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1)

https://fedoraproject.org/wiki/Package_Review_Process
| 
| Wait for someone to review your package! At this point in the process,
| the fedora-review flag is blank, meaning that no reviewer is assigned.

An incorrectly/mistakably set fedora-review flag causes the ticket to be listed as being worked on by somebody.

Updated to version 7 and fixed the warning mentioned on comment #2

SPEC file URL: http://snavin.fedorapeople.org/packages/sugar-america/sugar-america.spec

SRPM URL: http://snavin.fedorapeople.org/packages/sugar-america/sugar-america-7-1.fc18.src.rpm

Scratch build fails:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5483111

First I assumed we need python2-devel to run the setup script. But there seems to be a problem while unpacking the tarball:

+ /usr/bin/unzip -qq /builddir/build/SOURCES/i_know_america-7.xo
replace IknowAmerica.activity/locale/mi/activity.linfo? [y]es, [n]o, [A]ll, [N]one, [r]ename:  NULL
(EOF or read error, treating as "[N]one" ...)

Don't know what to do here. The source package creates the named folder and a folder with the same name inside...? That's strange. It leads to a prompt which asks for overwriting existing files.


BTW, I'm quite sure that it needs python2-devel anyway.

>+ /usr/bin/unzip -qq /builddir/build/SOURCES/i_know_america-7.xo
>replace IknowAmerica.activity/locale/mi/activity.linfo? [y]es, [n]o, [A]ll, >[N]one, [r]ename:  NULL
>(EOF or read error, treating as "[N]one" ...)

I could not find a solution to overcome this issue.

Please clear the whiteboard if the package becomes reviewable.

fixed the previous error and rebuild with latest version of the source.

SPEC URL: http://snavin.fedorapeople.org/packages/sugar-america/sugar-america.spec

SRPM URL: http://snavin.fedorapeople.org/packages/sugar-america/sugar-america-8-1.fc18.src.rpm

%{__python} is deprecated, use %{__python2} instead.

It seems that this review request is more advanced and up-to-date than https://bugzilla.redhat.com/show_bug.cgi?id=838252.

+ License is OK.
+ Sources are OK.
+ Packaging looks mostly OK.

- Note: No known owner of /usr/share/locale/quz,
     /usr/share/locale/ayc/LC_MESSAGES, /usr/share/locale/ayc,
     /usr/share/locale/quz/LC_MESSAGES

- Name is not OK: I think the name from https://bugzilla.redhat.com/show_bug.cgi?id=838252 (sugar-iknowamerica) is better, or maybe sugar-conozcoamerica should be used.

- Can you extend the description a bit: what is the age level of the game, what kind of a game it is, etc.

- /usr/share/sugar/activities/IknowAmerica.activity/recursos/comun/fuentes/Share-Regular.ttf is a font file and should be separated into a subpackage that this package depends on (https://fedoraproject.org/wiki/Packaging:FontsPolicy). (Unless it is packaged somewhere else, but I couldn't find it.)

Oh, the font is also in sugar-srilanka-0:1-4.fc20.noarch. It should be unbundled from both and shared.