Bug 842170
Summary: | list --consumed should not substitute "None" for null support level and type | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | John Sefler <jsefler> |
Component: | subscription-manager | Assignee: | Adrian Likins <alikins> |
Status: | CLOSED ERRATA | QA Contact: | Entitlement Bugs <entitlement-bugs> |
Severity: | high | Docs Contact: | |
Priority: | unspecified | ||
Version: | 5.9 | CC: | alikins, awood, jmolet, skallesh |
Target Milestone: | rc | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: |
Cause: Incorrect logic in the subscription-manager program.
Consequence: "None" was being printed for service levels where an empty string should have been printed instead.
Fix: Correcting the logic to recognize that an empty string represents a valid service level.
Result: The empty string will now be printed for the service level if appropriate.
|
Story Points: | --- |
Clone Of: | Environment: | ||
Last Closed: | 2013-01-08 03:57:35 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 771748 |
Description
John Sefler
2012-07-22 18:40:50 UTC
commit 736fbf8528776411f6df21eea58f2d96a0f449b4 Author: Adrian Likins <alikins> Date: Wed Aug 1 13:49:35 2012 -0400 842170: replace None service level/type with "" not None Empty or null/None service levels were being listed as None in list --consumed. Which is confusing since "None" (the string)[1] is a valid service level, so it was also wrong. Issue was "%s" % None or "blip", the % has precedence, so the LHS was always a non empty string (because we sub in a translated "None" string for None objects) and therefore never False. [1] yeah, I know... (out for review) This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux release for currently deployed products. This request is not yet committed for inclusion in a release. Marking verified!! Verifying version: [root@dhcp201-115 ~]# rpm -qa | grep subscription-manager subscription-manager-migration-data-1.11.2.2-1.git.2.c3c8e22.el5 subscription-manager-1.0.11-1.git.18.251f393.el5 subscription-manager-gui-1.0.11-1.git.18.251f393.el5 subscription-manager-firstboot-1.0.11-1.git.18.251f393.el5 subscription-manager-migration-1.0.11-1.git.18.251f393.el5 [root@dhcp201-115 ~]# subscription-manager register --username=testuser1 --password=password --org=admin --force The system has been registered with id: d5eff76a-0e8d-46b3-9307-0aaaf2ea2f68 [root@dhcp201-115 ~]# subscription-manager list --avail | grep awesomeos-virt-unlimited -B1 -A8 Subscription Name: Awesome OS with unlimited virtual guests SKU: awesomeos-virt-unlimited Pool Id: 8ac1493438e7fc1b0138e7fcd8eb0291 Quantity: 10 Service Level: Service Type: Multi-Entitlement: No Ends: 08/02/2013 Machine Type: physical Subscription Name: Awesome OS with unlimited virtual guests SKU: awesomeos-virt-unlimited Pool Id: 8ac1493438e7fc1b0138e7fcd92e0299 Quantity: 5 Service Level: Service Type: Multi-Entitlement: No Ends: 08/02/2013 Machine Type: physical [root@dhcp201-115 ~]# subscription-manager subscribe --pool 8ac1493438e7fc1b0138e7fcd92e0299 Successfully consumed a subscription for: Awesome OS with unlimited virtual guests [root@dhcp201-115 ~]# subscription-manager list --consumed Subscription Name: Awesome OS with unlimited virtual guests Provides: Awesome OS Server Bits SKU: awesomeos-virt-unlimited Contract: 108 Account: 12331131231 Serial Number: 2719650006605071289 Active: True Quantity Used: 1 Service Level: Service Type: Starts: 08/02/2012 Ends: 08/02/2013 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHBA-2013-0033.html |