Bug 842641

Summary:	RHEVM Installation: RHEVM Service doesn't follow SysV exit codes guidelines
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Ofer Schreiber <oschreib>
Component:	ovirt-engine-setup	Assignee:	Juan Hernández <juan.hernandez>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	medium	Docs Contact:
Priority:	high
Version:	3.1.0	CC:	bazulay, dyasny, iheim, mgoldboi, Rhev-m-bugs, sgrinber, ykaul
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	All
Whiteboard:	integration
Fixed In Version:	si12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-12-04 20:01:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ofer Schreiber 2012-07-24 10:19:30 UTC

Description of problem:
RHEVM Service (/etc/init.d/ovirt-engine) doesn't follow http://fedoraproject.org/wiki/Packaging:SysVInitScript#Exit_Codes_for_the_Status_Action and return 1 when service is down, pid exists or any other issue.

Version-Release number of selected component (if applicable):
SI11

How reproducible:
run:
 # service ovirt-engine status
 ovirt-engine is stopped

see RC:
 # echo $?
 1

  
Actual results:
rc is 1

Expected results:
0:	program is running or service is OK
1:	program is dead and /var/run pid file exists
2:	program is dead and /var/lock lock file exists
3:	program is not running
4:	program or service status is unknown
5-99:	reserved for future LSB use
100-149:	reserved for distribution use
150-199:	reserved for application use
200-254:	reserved

Comment 1 Juan Hernández 2012-07-25 10:03:13 UTC

The suggested fix for this bug is here:

http://gerrit.ovirt.org/6571

Comment 2 Juan Hernández 2012-07-26 11:22:59 UTC

The change has already been merged upstream:

http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=6a70668ecf4fa1290176bc4248c2ca2801b55df8