Bug 843380
Summary: | [admin-portal] Add disk dialogue: filter out DC with status != 'UP' (Error in retrieving the relevant Storage Domain) | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Virtualization Manager | Reporter: | vvyazmin <vvyazmin> | ||||
Component: | ovirt-engine-webadmin-portal | Assignee: | Daniel Erez <derez> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | vvyazmin <vvyazmin> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | unspecified | ||||||
Version: | 3.1.0 | CC: | abaron, amureini, dyasny, ecohen, hateya, iheim, Rhev-m-bugs, sgrinber, ykaul | ||||
Target Milestone: | --- | ||||||
Target Release: | 3.1.0 | ||||||
Hardware: | x86_64 | ||||||
OS: | Linux | ||||||
Whiteboard: | storage | ||||||
Fixed In Version: | SI15 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2012-12-04 20:03:49 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | Storage | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
(In reply to comment #0) > > Expected results: > Prevent display DC that have “Uninitialized” status in drop down box “Data > Center” in UI “Add Virtual Disk”. Display only DC’s that have “Up” status > I don't agree it is the right solution. * What happens if a storage domain goes into maintenance/non operational after the list generated? What should be done is a better text message saying something like: "Can't create a disk, the selected data center status is: __Status__" P.S. Did you get that as soon as you've selected the DC? IE before pressing OK? I get an error before pressing OK when you select from drop list “Uninitialized” DC, you get this error (In reply to comment #1) > (In reply to comment #0) > > ... > > What should be done is a better text message saying something like: > "Can't create a disk, the selected data center status is: __Status__" > > ... > This is not consistent with the behavior of the application: In all dialogs, we always filter out the non-"active" entities; e.g. in New VM dialog, we show only "Up" DCs, "OK" Templates, "Active" Storage Domains, etc. Showing also non-"active" entities in dialogs can result in lots of messages like the one that you suggested above, which is bad UX IMO. - For "New Disk" dialog opened from Disks main tab: Non-Up DCs should be filtered out; if no Up DCs exist in the system (i.e. "DC" and "SD" drop-downs are empty), there should be a relevant message (such as: "There are no active Data-Centers in the system") - For "New Disk" dialog opened from a VM context: If the relevant DC is not Up (i.e. there are no active SDs in the DC), there should be a relevant message (such as" There are no active Storage Domains in the relevant Data-Center"). (In reply to comment #4) > - For "New Disk" dialog opened from Disks main tab: Non-Up DCs should be > filtered out; if no Up DCs exist in the system (i.e. "DC" and "SD" > drop-downs are empty), there should be a relevant message (such as: "There > are no active Data-Centers in the system") > > - For "New Disk" dialog opened from a VM context: If the relevant DC is not > Up (i.e. there are no active SDs in the DC), there should be a relevant > message (such as" There are no active Storage Domains in the relevant > Data-Center"). Ack. patch merged upstream: http://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=commit;h=38b19de85c75dd1c1294b77b501f3cfd50ba4a90 Verified on RHEVM 3.1 - SI15 RHEVM: rhevm-3.1.0-13.el6ev.noarch VDSM: vdsm-4.9.6-29.0.el6_3.x86_64 LIBVIRT: libvirt-0.9.10-21.el6.x86_64 QEMU & KVM: qemu-kvm-rhev-0.12.1.2-2.298.el6_3.x86_64 SANLOCK: sanlock-2.3-3.el6_3.x86_64 |
Created attachment 600452 [details] ## screen-shot Description of problem: In UI “Add Virtual Disk”, drop down box “Data Center” display DC’s that have “Uninitialized” status Version-Release number of selected component (if applicable): RHEVM 3.1 - SI11 RHEVM: rhevm-3.1.0-7.el6ev.noarch.rpm VDSM: vdsm-4.9.6-23.0.el6.x86_64 LIBVIRT: libvirt-0.9.10-21.el6.x86_64 QEMU & KVM: qemu-kvm-rhev-0.12.1.2-2.295.el6.x86_64 SANLOCK: sanlock-2.3-2.1.el6.x86_64 How reproducible: 100% Steps to Reproduce: 1. Create a new DC (Status: Uninitialized) 1. For example: DC-02-iSCSI 2. Add a new disk via “Disks” tab Actual results: Get error: Error in retrieving the relevant Storage Domain. (print screen attached) Expected results: Prevent display DC that have “Uninitialized” status in drop down box “Data Center” in UI “Add Virtual Disk”. Display only DC’s that have “Up” status Additional info: