Bug 843393
| Summary: | Designer Task Data Assignments and Commas | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [JBoss] JBoss Enterprise BRMS Platform 5 | Reporter: | Toshiya Kobayashi <tkobayas> | ||||||||
| Component: | jBPM 5 | Assignee: | Kris Verlaenen <kverlaen> | ||||||||
| Status: | VERIFIED --- | QA Contact: | |||||||||
| Severity: | high | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | BRMS 5.3.0.GA | CC: | kverlaen | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: |
When users added comma to the comment field of the user task in the Process Designer, the user task would not be parsed properly because there was no support for commas. The Process Designer now includes support for commas.
|
Story Points: | --- | ||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | Type: | Bug | |||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Toshiya Kobayashi
2012-07-26 08:37:59 UTC
Tihomir Surdilovic <tsurdilo> made a comment on jira JBPM-3676 Yes currently comma is used to separate the values internally. This will change in Designer 2.4. I cannot break the compatibility in 2.3 from 2.2 on consecutive releases. However when this is fixed after the Designer 2.3 release I will provide a war file with the fix here asap so you guys can start using it. Hope this is OK with everyone. Tihomir Surdilovic <tsurdilo> updated the status of jira JBPM-3676 to Resolved Tihomir Surdilovic <tsurdilo> made a comment on jira JBPM-3676 Fix committed to master. Will be available in Designer 2.4.0 release Toshiya, JBPM-3676 is resolved now in community. One thing I could use some help on is what branch the fix needs to go into. BRMS 5.3 Designer was released from the https://github.com/droolsjbpm/jbpm-designer/tree/2.2.x branch. Since then we released Designer 2.3.0.Final in the community which uses the 2.3.x branch. I don't know if next release of Designer will use the 2.2.x or the 2.3.x branch..let me know what productization decides to do here. I would assume they use 2.3.x Prakash told that 2.3.x is the one. Thanks! *** Bug 852108 has been marked as a duplicate of this bug. *** This is fixed now. I can still reproduce this bug on BRMS 5.3.1 ER1 and Designer 2.3.1-DEV Editor for Data Assigment do not allow me put property "Commnad" into field From Object. I must write it directly into input field of property "Assigments". - Comment=aaaa,bbb If I open Editor for Data Assigments again I can see same result which is capture on screenshots in jira JBPM-3676 I am not sure what to do about users typing in directly text into the input field and bypassing the editor. If using the editor works as expected then this should be the fix for this unless you guys disagree. let me know..thanks. > Sona You can input the value (e.g. aaa,bbb) in "Comment" property of a Task node. Isn't it good for the test? > Tiho With Designer 2.3.1-DEV, I see the Comment value is wrpped by CDATA in bpmn2 so the fix seems to be fine. But I don't see any entry in "Data Assignments" after adding Comment while BRMS 5.3.0 shows an entry for Comment (and TaskName). Is this an intentinal change? I guess it's not a problem anyway... Tihomir Surdilovic <tsurdilo> made a comment on jira JBPM-3676 @Toshiya, yes that was done by design. The Comment data input is still added tho in both data inputs and the data assignments in the bpmn2. For Jira issue: verified for BRMS 5.3.1 ER1 and designer 2.3.1-DEV
Steps of verification:
1. create new process in empty repository
2. add email service task
3. open editor for data assignments and write string value into field ("aaaa,bbbb")
4. close and reopen
Everything is ok. No another variables are visible. Text in Assignment field is Subject=aaa##bbb,To=,From=,Body=
But still I do not know steps to reproduce issue in Bugzilla. If I type "aaa,bbb" into Comment property and open Editor for Data Assignments of property Assignments, then I cannot see Comment as From Object in assignments.
Same behaviour for BRMS 5.3.0 ER9.
Screenshot is attached.
Created attachment 619781 [details]
Editor for Data Assignments - Text in Comment property contains comma
Created attachment 620108 [details]
repository_export_comma_comment_disordered.xml
Created attachment 620109 [details]
jBPMEx29_comma_comment_verify
Hi Sona,
> still I do not know steps to reproduce issue in Bugzilla.
'To reproduce', you need to save the process after adding Comment property. Sorry about missing it in the initial description. Of course you need to test with 5.3.0.GA. Attached my repository_export_comma_comment_disordered.xml.
For 5.3.1.ER1, as Tiho commented, Designer doesn't show Comment property in "Data Assignments" windows. So 'to verify the fix', we need to look into bpmn2 file itself and confirm that "aaaa, bbbb" is surrounded by CDATA. Also I have attached a JBDS project which confirms that a task client can get the comment value.
Cheers,
For Bugzilla issue: verified for BRMS 5.3.1 ER1 and designer 2.3.1 - DEV Steps of verification: 1. Create new process in empty repository 2. add human task and set its property Comment to "aaaa,bbb" 3. save process then check property in designer and in BPMN2 source code (contains CDATA). Thanks Toshiya, your repository help me. |