Bug 844202
| Summary: | Common Content reverts back to en-US when a language without a region is used | ||
|---|---|---|---|
| Product: | [Community] Publican | Reporter: | Lee Newson <lnewson> |
| Component: | publican | Assignee: | Jeff Fearn 🐞 <jfearn> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | tools-bugs <tools-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.0 | CC: | aigao, mhusnain, mmcallis, rlandman |
| Target Milestone: | 3.2 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 3.2.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-08-09 04:48:47 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lee Newson
2012-07-30 00:47:18 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle. Changing version to '19'. (As we did not run this process for some time, it could affect also pre-Fedora 19 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19 Moving this upstream Mapped two letter language codes to existing translations where there was no apparent contention between existing translations. To ssh://git.fedorahosted.org/git/publican.git 99e013c..d616cb5 HEAD -> devel Checked with publican-3.1.5-0.fc19.t62.noarch Appears in Japanese: * Preface (Ch 1) Does not appear in Japanese: * Legal Notice * Feedback information (Ch 2) (In reply to Misha H. Ali from comment #5) > Checked with publican-3.1.5-0.fc19.t62.noarch > > Appears in Japanese: > > * Preface (Ch 1) Does the text of Document Conventions appear in Japanese? If so, the fix for this bug is Verified, because: > Does not appear in Japanese: > > * Legal Notice we don't ship translations of legal notices and > * Feedback information (Ch 2) depending on the brand, this might not ever have been translated (In reply to Ruediger Landmann from comment #6) > (In reply to Misha H. Ali from comment #5) > > Checked with publican-3.1.5-0.fc19.t62.noarch > > > > Appears in Japanese: > > > > * Preface (Ch 1) Yes > > Does the text of Document Conventions appear in Japanese? If so, the fix for > this bug is Verified, because: > > > Does not appear in Japanese: > > > > * Legal Notice > > we don't ship translations of legal notices and OK > > > * Feedback information (Ch 2) > > depending on the brand, this might not ever have been translated Checked with the JBoss and RedHat brands. Assuming the lack of translation for feedback is intentional, this bug is VERIFIED. The RedHat and JBoss brands Feedback.xml have both been translated for Japanese, so it should be displaying that content I believe. eg: JBoss brand: https://access.redhat.com/site/documentation/ja-JP/JBoss_Enterprise_Application_Platform/6/html/Administration_and_Configuration_Guide/sect_JBoss-Getting_Help_and_Giving_Feedback.html RedHat brand: https://access.redhat.com/site/documentation/ja-JP/Red_Hat_Enterprise_Linux/6/html/Virtualization_Administration_Guide/sect_RedHat-Getting_Help_and_Giving_Feedback.html I'll build publican from source today/tomorrow and try it myself just to verify (so leaving it as VERIFIED until then). Okay I've verified what Misha said in Comment #5. The problem as far as I can tell is that the patch only handles getting mapped content from the base_brand and not the brand itself (see line 742 in https://git.fedorahosted.org/cgit/publican.git/tree/publican/lib/Publican/Builder.pm?h=devel&id=d616cb5cfb0bf3fc907106d4c25c576343507b45). This would explain why the overridden en-US JBoss/RedHat Feedback.xml is being copied but not the ja-JP Feedback.xml I believe. Thanks for the patch! To ssh://git.fedorahosted.org/git/publican.git 97b5356..a4b3bc2 HEAD -> devel I'm happy to retest this, but do I need to update my publican or something to get the new patch first? (In reply to Misha H. Ali from comment #12) > I'm happy to retest this, but do I need to update my publican or something > to get the new patch first? Thanks Misha -- try this: https://fedorahosted.org/publican/wiki/Installing#Upgradingtoanewdevelopmentversion Yeah Misha you'd need to recompile from the latest source. These should be the steps you need to do: 1. Change into the publican git repo (I'm going to assume you still have the devel branch checked out). 2. git pull 3. Change into the "publican" directory. 4. (Maybe) perl Build.PL 5. ./Build local For what it's worth, this now works as I'd expect (checking html, html-single and pdf) using publican-3.1.5-0.fc18.t64.noarch Ignore the process I said sorry Misha, what Rudi said definitely looks like the way to go :) Followed instructions from comment #13 to upgrade to publican-3.1.5-0.fc19.t65.noarch The following now appear translated as expected: * Document Conventions * Getting Help and Giving Feedback Thanks Lee and Rudi! The fix for this bug has been shipped in publican 3.2.0 |