Bug 844426

Summary:	mcollective-qpid-plugin needs License file
Product:	OKD	Reporter:	Troy Dawson <tdawson>
Component:	Pod	Assignee:	Krishna Raman <kraman>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	jialiu, mfisher
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-08-07 20:42:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Troy Dawson 2012-07-30 14:53:41 UTC

Description of problem:
The mcollective-qpid-plugin has no license file.
End users may be confused what license this plugin is under.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Checkout crankcase code (git clone https://github.com/openshift/crankcase.git)
2. cd crankcase/gearchanger/mcollective/qpid-plugin
3. ls *
  
Actual results:
Two files are shown.  mcollective-qpid-plugin.spec and src/qpid.rb

Expected results:
At least one file called LICENSE or something similar.

Additional info:
According to the mcollective-qpid-plugin.spec file, qpid.rb is licensed under the ASL 2.0 license.  That is the license file that should be put in the directory.

Comment 1 Troy Dawson 2012-07-30 15:17:17 UTC

The COPYRIGHT file is also missing.

Comment 2 Krishna Raman 2012-07-30 16:41:29 UTC

https://github.com/openshift/crankcase/pull/298

Comment 3 Johnny Liu 2012-08-01 08:40:53 UTC

Verified this bug with devenv_1931, and PASS.

# rpm -ql mcollective-qpid-plugin-0.1.3-1.el6_3.noarch
/usr/libexec/mcollective/mcollective/connector/qpid.rb
/usr/share/doc/mcollective-qpid-plugin/COPYRIGHT
/usr/share/doc/mcollective-qpid-plugin/LICENSE
/usr/share/doc/mcollective-qpid-plugin/README.md

# cat /usr/share/doc/mcollective-qpid-plugin/COPYRIGHT
Copyright 2012 Red Hat, Inc. and/or its affiliates.
You have new mail in /var/spool/mail/root

# cat /usr/share/doc/mcollective-qpid-plugin/LICENSE
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

   http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.