Bug 844683

Summary:	[RFE] mingw-virt-viewer: use ASLR
Product:	Red Hat Enterprise Linux 8	Reporter:	Tomas Jamrisko <tjamrisk>
Component:	mingw-virt-viewer	Assignee:	Uri Lublin <uril>
Status:	CLOSED ERRATA	QA Contact:	SPICE QE bug list <spice-qe-bugs>
Severity:	low	Docs Contact:
Priority:	low
Version:	8.4	CC:	cfergeau, mdean, mkrcmari, mtessun, rh-spice-bugs, tpelka, uril, victortoso
Target Milestone:	rc	Keywords:	FutureFeature, Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	mingw-virt-viewer-9.0-3.el8	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-18 16:20:32 UTC	Type:	Feature Request
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Spice	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tomas Jamrisko 2012-07-31 11:54:18 UTC

Description of problem:

virt-viewer for windows does not support ASLR. This is pretty much a regression as spice client had this bug (#701111) resolved in an errata.


Version-Release number of selected component (if applicable):
mingw-virt-viewer-0.5.3-8.el6

How reproducible:
Always

How to check:
1. Get Process explorer (http://technet.microsoft.com/en-us/sysinternals/bb896653.aspx)
2. Start remote-viewer
3. Take a look at remote-viewer in Process Explorer ( enable 'ASLR enabled' column)

Expected: 

ASLR should be enabled (obviously)

Comment 6 David Blechter 2013-08-09 08:33:25 UTC

postpone it to the next release, no solution yet

Comment 8 Christophe Fergeau 2015-06-04 16:07:22 UTC

Seems like it's possible to enable ASLR with mingw-w64 builds using some hacks:
http://sourceforge.net/p/mingw-w64/mailman/mingw-w64-public/thread/CAGFXeQKg0J+ax0Dj-cBXGGrwWT15K-aRsWWaBN6wWSDUtRHoLg@mail.gmail.com/

Comment 14 Sandro Bonazzola 2017-12-20 13:59:28 UTC

oVirt 4.2.0 has been released on Dec 20th 2017. Please consider re-targeting this bug to next milestone

Comment 15 Sandro Bonazzola 2019-01-28 09:43:45 UTC

This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 20 Martin Tessun 2019-11-25 07:46:21 UTC

With the move to mingw we lost the easy ability doing ASLR. We are looking into it, but it requires changes and reviews to 68 packages.

So don't expect any solution anytime soon.

Comment 21 Frediano Ziglio 2020-08-26 13:26:59 UTC

The issue is the support in MingW, see https://github.com/msys2/MINGW-packages/issues/5719 and https://github.com/msys2/MINGW-packages/issues/3035, just a question of some flags.
-Wl,--dynamicbase,--high-entropy-va,--nxcompat seems good in Fedora 31.

Comment 22 Frediano Ziglio 2020-08-26 13:37:52 UTC

I just tried, it does not work even on Fedora 31.

Comment 23 Frediano Ziglio 2020-08-28 13:52:52 UTC

My fault, apparently now it's working https://gitlab.com/virt-viewer/virt-viewer/-/commit/28a330758faa31b93e836b2bed2ec6a30a29a123

Comment 27 Frediano Ziglio 2020-10-20 13:18:20 UTC

Tomas, you can look at Process explorer to check that the option is working.

Do we need a pm_ack?

Comment 37 errata-xmlrpc 2021-05-18 16:20:32 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (spice-client-win bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1947