Bug 844755

Summary:	Review Request: select2 - jQuery based replacement for select boxes
Product:	[Fedora] Fedora	Reporter:	Richard Marko <rmarko>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jberan, notting, package-review, rmarko
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-07-03 13:21:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard Marko 2012-07-31 16:18:33 UTC

Spec URL: http://rmarko.fedorapeople.org/packages/select2.spec
SRPM URL: http://rmarko.fedorapeople.org/packages/select2-2.1-1.fc17.src.rpm
Description: jQuery based replacement for select boxes
Fedora Account System Username: rmarko

rpmlint complains about E: wrong-script-end-of-line-encoding /usr/share/doc/select2-2.1/README.md - this is caused by upstream marking README.md as executable in git, I will report this issue upstream.

Another minor issue - LICENSE file which is present in upstream git is copied to README.md during release process which I'm not sure if it's against packaging guidelines.

Comment 1 Jason Tibbitts 2013-06-10 23:23:07 UTC

I am triaging old review tickets.  I can't promise a review if you reply, but by closing out the stale tickets we can devote extra attention to the ones which aren't stale.

Pretty sure that simply bundling the minimized version violates our requirements that everything be build from source.  jsmin itself isn't free software, so if you needed to patch the .js file for some reason, you'd have no way to recreate the minimized version.

You should fix the rpmlint issue by calling chmod in your spec.

I'm afraid I don't understand your final comment.  All we care about is getting the proper license information included in the package.  It doesn't particularly matter what the file is called.

This package would appear to be significantly out of date after all this time.

Comment 2 Richard Marko 2013-07-03 13:21:03 UTC

It should be possible to use uglify.js which is packaged in Fedora to create minified versions but I have no interest to finish it at this time.

I'll open a new request if I get back to it.