Bug 844817
| Summary: | Review Request: rubygem-openshift-origin-dns-bind - OpenShift plugin for BIND service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | admiller, maxamillion, misc, notting, package-review, tcallawa |
| Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-09-17 22:17:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 839064 | ||
| Bug Blocks: | |||
|
Description
Troy Dawson
2012-07-31 22:55:20 UTC
*** Bug 842459 has been marked as a duplicate of this bug. *** I would like to add FAS account name maxamillion to this review as I'll be out of town for the next week and don't want to be a blocker. Fedora Account System Username: maxamillion tdawson Does this need the non rubygem subpackage? The guidelines state that this is no longer needed: https://fedoraproject.org/wiki/Packaging/Ruby#Packaging_for_Gem_and_non-Gem_use There is also this from rpmlint: rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/keyname-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/cache.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/server-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/port-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/keyvalue-i.ri Should be easy to fix (sed -i 's/\r//' $FILE). rubygem-openshift-origin-dns-bind.noarch: W: unexpanded-macro /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/namespace_available%3f-i.ri %3f I _think_ this is a false positive, because the file name contains "%3f", but you should check to ensure that filename is correct, it seems odd. Nope, that's correct, there is lots of ruby package who do this on all linux distributions, that's a false positive. SPEC URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-dns-bind.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-dns-bind-0.8.5-5.fc17.src.rpm Removed non-gem subpackage and attempted to clean up the wrong-file-end-of-line-encoding and appeared to get all but 2 of them (not entirely sure why sed didn't clean up that last two but I'm open to suggestions ... I struck out in search of an answer). Hi, Please don't fix the "wrong-file-end-of-line" problems on the gems. On one of my other reviews Vic stated that this is a false positive on ruby gems and that he is working on fixing rpmlint. https://bugzilla.redhat.com/show_bug.cgi?id=831749#c31 SPEC URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-dns-bind.spec SRPM URL: http://maxamillion.fedorapeople.org/rubygem-openshift-origin-dns-bind-0.8.5-6.fc17.src.rpm "Fixed" the wrong-file-end-of-line-encoding false positives. = REVIEW = - rpmlint returns: rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/keyname-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/cache.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/server-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/port-i.ri rubygem-openshift-origin-dns-bind.noarch: W: wrong-file-end-of-line-encoding /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/keyvalue-i.ri rubygem-openshift-origin-dns-bind.noarch: W: unexpanded-macro /usr/share/gems/doc/openshift-origin-dns-bind-0.8.5/ri/Uplift/BindPlugin/namespace_available%3f-i.ri %3f 2 packages and 0 specfiles checked; 0 errors, 6 warnings. All safe to ignore on ruby packages. - package meets naming guidelines - package meets packaging guidelines (ruby) - license (ASL 2.0) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (a996982574791a49c74e422ab2eef3c7510af46c6b0b96fa05d5f3dcefc575e2) - package compiles on devel (noarch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED. New Package SCM Request ======================= Package Name: rubygem-openshift-origin-dns-bind Short Description: OpenShift plugin for BIND service Owners: maxamillion tdawson Branches: f17 f18 el6 InitialCC: Already exists. rubygem-openshift-origin-dns-bind-0.8.5-7.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-openshift-origin-dns-bind-0.8.5-7.fc18 rubygem-openshift-origin-dns-bind-0.8.5-7.fc18 has been pushed to the Fedora 18 testing repository. rubygem-openshift-origin-dns-bind-0.8.5-7.fc18 has been pushed to the Fedora 18 stable repository. |