Bug 844909
Summary: | RFE: Add cache mode "directsync" and "unsafe" | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Daisy Wu <jwu> | ||||||
Component: | python-virtinst | Assignee: | virt-mgr-maint | ||||||
Status: | CLOSED DUPLICATE | QA Contact: | Virtualization Bugs <virt-bugs> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | 6.3 | CC: | dallan, gscrivan, juzhou, martin.millnert, mzhan, rwu, tzheng, yupzhang, zpeng | ||||||
Target Milestone: | rc | Keywords: | FutureFeature | ||||||
Target Release: | --- | ||||||||
Hardware: | x86_64 | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Enhancement | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2012-08-01 16:01:05 UTC | Type: | Bug | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Daisy Wu
2012-08-01 08:55:03 UTC
*** This bug has been marked as a duplicate of bug 844907 *** Created attachment 990838 [details] Patch to add support for cache=unsafe, directsync This bug has been *incorrectly* marked as duplicate of 844907. This RFE/bug reports regards **virt-install**, bug 844907 regards **virt-manager** - these are two distinct and unique programs. This bug is *not* resolved in rhel 7. The two cache modes unsafe and directsync are still missing on virt-install (virt-install-0.10.0-20.el7.noarch). I've supplied a patch against the installed code of virtinstall-0.10.0-20.el7.noarch (located in /usr/share/virt-manager/ ) Tested and works for me: [root@localhost bin]# grep --color=auto cache /etc/libvirt/qemu/ft-qcow-directsync-test.xml <driver name='qemu' type='qcow2' cache='directsync' io='native'/> [root@localhost bin]# grep --color=auto cache /etc/libvirt/qemu/ft-qcow-unsafe-test.xml <driver name='qemu' type='qcow2' cache='unsafe' io='native'/> BR, Martin Millnert Created attachment 990842 [details]
Patch to add support for cache=unsafe, directsync (v2)
Resubmitting the patch to add support for cache=[unsafe|directsync], this time in proper order.
Thanks for the patch, this feature will be present in RHEL-7.1 as virt-manager was rebased on top of the upstream version 1.1.10 which already has this feature. Try to test with the two cache mode: unsafe and directsync on RHEL-7.1. packages: virt-manager-common-1.1.0-12.el7.noarch virt-install-1.1.0-12.el7.noarch virt-manager-1.1.0-12.el7.noarch From virt-manager GUI checking: 1.Launch virt-manager: #virt-manager 2.Double-click a vm and click the Run button in the Virtual Machine Details window. 3.Click the Hardware tab. 4.Click Add Hardware button 5.Select Storage in Hardware type droplist and click Forward. 6.Select managed or other existing storage and fill out the Location of Block device(partition), eg: /dev/sda3. 7.Select vitual disk in Device type then click Forward. 8.Click Finish button. 9.Reboot vm and check Hardware tab. 10.loop upper steps with all options of cache mode: default, none, writeback, writethrough, unsafe, directsync Result: All cache modes work well. From virt-install cmd checking: 1. Check virt-install man page: # man virt-install ... cache The cache mode to be used. The host pagecache provides cache memory. The cache value can be 'none', 'writethrough', or 'writeback'. 'writethrough' provides read caching. 'writeback' provides read and write caching. ... Result: cannot find unsafe, directsync mode. 2. Try to install guest with the two cache mode: 2.1 cache=unsafe # virt-install --name cache-unsafe --ram 1024 --vcpu=1 --disk path=/var/lib/libvirt/images/cache-unsafe.img,size=6,cache=unsafe --location /var/lib/libvirt/images/RHEL-6.6-20140926.0-Server-x86_64-dvd1.iso Starting install... Retrieving file .treeinfo... | 5.4 kB 00:00:00 Retrieving file vmlinuz... | 7.9 MB 00:00:00 ... Result: Installation finished with no error. # grep --color=auto cache /etc/libvirt/qemu/cache-unsafe.xml virsh edit cache-unsafe <name>cache-unsafe</name> <driver name='qemu' type='raw' cache='unsafe'/> <source file='/var/lib/libvirt/images/cache-unsafe.img'/> 2.2 cache=directsync # virt-install --name cache-directsync --ram 1024 --vcpu=1 --disk path=/var/lib/libvirt/images/cache-directsync.img,size=6,cache=directsync --location /var/lib/libvirt/images/RHEL-6.6-20140926.0-Server-x86_64-dvd1.iso Starting install... Retrieving file .treeinfo... | 5.4 kB 00:00:00 Retrieving file vmlinuz... | 7.9 MB 00:00:00 ... Result: Installation finished with no error. # grep --color=auto cache /etc/libvirt/qemu/cache-directsync.xml virsh edit cache-directsync <name>cache-directsync</name> <driver name='qemu' type='raw' cache='directsync'/> <source file='/var/lib/libvirt/images/cache-directsync.img'/> As a result, the two cache mode works well for virt-manager and virt-install cmd, so Giuseppe Scrivano, i think we should add them to virt-install man page, and will we file a bug to track this manual issue, please help check it, thanks. thanks to have noticed that. I have proposed a patch to fix it: https://www.redhat.com/archives/virt-tools-list/2015-February/msg00034.html |