Bug 845096
| Summary: | Some types of notifications don't go away on their own | ||
|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Og Maciel <omaciel> |
| Component: | WebUI | Assignee: | Brad Buckingham <bbuckingham> |
| Status: | CLOSED ERRATA | QA Contact: | Og Maciel <omaciel> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 6.0.1 | CC: | achan, asettle, dmacpher, gstoecke, mmccune |
| Target Milestone: | Unspecified | Keywords: | TestBlocker, Triaged |
| Target Release: | Unused | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Success messages/notices on the dashboard behaved like warnings. They required manual closure instead of being automatic dismissal. This fix modifies the notification code and changes all success notifications to not remain permanently on the dashboard.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-04 19:50:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Og Maciel
2012-08-01 18:40:57 UTC
The only thing that should stay on the screen are errors and warnings. everything else should fade out The real issue here is not about the fading. The problem is that a notification containing a successful message was displayed as gray "message" type, when it should be a green "success" type. The promotion success message is now gray, it was (and should be) green. Prior to the bz there was some refactoring done on notices. When that happened the promotions 'success' notice was incorrectly updated to be a 'message' notice (i.e. notify.message / Notify.message). The 'message' class will create a notice that when displayed has a grayish background and is 'sticky', requiring the user to manually close it. From a scan of the code (i.e. [n|N]otify.message), the only usages of the 'message' class were: 1. notice created after successful promotion 2. notice created when a newly created object no longer meets current search criteria for the page 3. notice created when a user's default environment has been removed and user is informed to select another one 1, should be defined as a success. 2 & 3 were intentionally defined as 'message' because they are not errors, but the user should be aware. The following katello commit addresses the issue of the promotion notice: https://github.com/Katello/katello/commit/ea18172fbbb7c993e35f12a8b5a5b7f0f1c7cd81 Verified using: * candlepin-0.7.8-1.el6cf.noarch * candlepin-selinux-0.7.8-1.el6cf.noarch * candlepin-tomcat6-0.7.8-1.el6cf.noarch * katello-1.1.12-7.el6cf.noarch * katello-all-1.1.12-7.el6cf.noarch * katello-candlepin-cert-key-pair-1.0-1.noarch * katello-certs-tools-1.1.8-1.el6cf.noarch * katello-cli-1.1.8-4.el6cf.noarch * katello-cli-common-1.1.8-4.el6cf.noarch * katello-common-1.1.12-7.el6cf.noarch * katello-configure-1.1.9-3.el6cf.noarch * katello-glue-candlepin-1.1.12-7.el6cf.noarch * katello-glue-pulp-1.1.12-7.el6cf.noarch * katello-qpid-broker-key-pair-1.0-1.noarch * katello-qpid-client-key-pair-1.0-1.noarch * katello-selinux-1.1.1-1.el6cf.noarch * pulp-1.1.12-1.el6cf.noarch * pulp-common-1.1.12-1.el6cf.noarch * pulp-selinux-server-1.1.12-1.el6cf.noarch Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2012-1543.html getting rid of 6.0.0 version since that doesn't exist |