Previously, the fenced daemon was creating its log file with insecure permissions. Even though no sensitive data, such as passwords, usernames, or IP addresses were ever stored in the file, with this update, log files are created with correct permissions. Permissions of an existing log file is also automatically corrected if necessary.
Description of problem:
fenced creates its log file with permissions of 666. It should create it with permissions of 644 or better, like the rest of the cluster-related logs.
The problem is at line 1042 in fence/fenced/main.c.
Version-Release number of selected component (if applicable):
cman-3.0.12.1-32.el6.x86_64
How reproducible:
always
Steps to Reproduce:
1. configure cluster
2. start cluster
3. ls -l /var/log/cluster/fenced.log
Actual results:
666
Expected results:
644
Additional info:
The problem is that the daemon is doing umask(0), causing the fopen() within liblogthread to use 666. I'll remove umask(0), but that won't fix the 666 permission on existing files. Any suggestions about whether I should also add a chmod("/var/log/cluster/fenced.log", 666) to fix the existing files?
Created attachment 602152[details]
patch
Remove umask(0) which caused liblogthread's fopen to
create fenced.log with mode 666.
Check if existing fenced.log has mode 666 and if so,
chmod to 644.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.
http://rhn.redhat.com/errata/RHBA-2013-0287.html