Bug 845394

Summary: pgpool-II spec file enhancements for easy build of the package for EPEL + addition of "recovery" subpackage
Product: [Fedora] Fedora Reporter: Dmitry S. Makovey <dmitry>
Component: postgresql-pgpool-IIAssignee: Devrim Gündüz <devrim>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 17CC: devrim, rdieter, tcallawa
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-12-20 16:15:14 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Diff against original SPEC file
none
init script for non-systemd platforms
none
Updated SPEC file diff with "replication" sub-package
none
Full SPEC file as used on RHEL6
none
Updated with recovery subpackage patch
none
Updated Full SPEC file as used on RHEL6 none

Description Dmitry S. Makovey 2012-08-02 23:06:10 UTC
Created attachment 602037 [details]
Diff against original SPEC file

Description of problem:

Current SPEC file for pgpool-II (postgresql-pgpool-II) is broken when used to build for RHEL* systems due to it's reliance on systemd. I've attached a patch that should address that. Using provided SPEC file it should become seamless to build package on either system (Fedora or RHEL) resulting in an applicable package

Version-Release number of selected component (if applicable):

3.1.2-1

How reproducible:

always

Steps to Reproduce:
1. try to build postgresql-pgpool-II-3.1.2-1.f17.src.rpm on RHEL6 machine.
  
Actual results:

failure


Expected results:

built binary packages that work on RHEL6

Additional info:

We are planning on using pgpool-II in production on RHEL platform thus I could work on porting future versions to RHEL platform in a compatible fashion...

Comment 1 Dmitry S. Makovey 2012-08-02 23:07:13 UTC
Created attachment 602038 [details]
init script for non-systemd platforms

Comment 2 Dmitry S. Makovey 2012-08-17 16:41:46 UTC
Created attachment 605228 [details]
Updated SPEC file diff with "replication" sub-package

In the meantime I have updated SPEC to also build sql/pgpool-recovery as it seems to be required for streamed replication and recovery. sql/pgpool-walrecrunning does seem to be required too but on RHEL it won't build, I'm assumbing due to the too low version of PostgreSQL (8.4) but pgpool-recovery should really suffice.

Comment 3 Dmitry S. Makovey 2012-08-17 16:42:36 UTC
Created attachment 605229 [details]
Full SPEC file as used on RHEL6

Comment 4 Dmitry S. Makovey 2012-09-14 19:51:15 UTC
Created attachment 612980 [details]
Updated with recovery subpackage patch

I have been working with this package and found that adding replication sample scripts to the package would be reasonable, so package is updated to reflect that.

Comment 5 Dmitry S. Makovey 2012-09-14 19:52:03 UTC
Created attachment 612981 [details]
Updated Full SPEC file as used on RHEL6

Comment 6 Tom "spot" Callaway 2012-09-19 20:54:56 UTC
Your work is a very good start, but not 100% complete. I'll commit a fixed version of your changes that is a bit cleaner at the same time that I push 3.2.0.

Comment 7 Dmitry S. Makovey 2012-09-19 21:43:02 UTC
Tom, I can track Koji (?) and report on applicability of EPEL builds of those packages if you'd like an extra pair of eyes.

Comment 8 Fedora Update System 2012-09-19 21:53:18 UTC
postgresql-pgpool-II-3.2.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/postgresql-pgpool-II-3.2.0-1.fc18

Comment 9 Fedora Update System 2012-09-19 21:53:28 UTC
postgresql-pgpool-II-3.2.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/postgresql-pgpool-II-3.2.0-1.el6

Comment 10 Fedora Update System 2012-09-20 05:58:55 UTC
Package postgresql-pgpool-II-3.2.0-1.fc18:
* should fix your issue,
* was pushed to the Fedora 18 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing postgresql-pgpool-II-3.2.0-1.fc18'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-14394/postgresql-pgpool-II-3.2.0-1.fc18
then log in and leave karma (feedback).

Comment 11 Fedora Update System 2012-12-20 16:15:16 UTC
postgresql-pgpool-II-3.2.0-1.fc18 has been pushed to the Fedora 18 stable repository.  If problems still persist, please make note of it in this bug report.