Bug 845465
| Summary: | Review Request: python-django-celery - Django Celery Integration | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Runge <mrunge> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-06 05:44:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 736776, 840359 | ||
|
Description
Matthias Runge
2012-08-03 07:20:20 UTC
I'll take it for a review. - Your changelog mentions updating to version 3.0.5, but the actual version is 3.0.4, please fix this. - The package includes some tests, have you tried running them? It seems that after some playing with them, they may be runnable via nosetests, although I'm not sure it's doable without django_nose (which we don't have in Fedora). I'm honestly sorry! I had put those files on my webspace and ran rpmlint later. I just have forgotten to replace those files the corrected versions. It's done now. I must say, didn't try the checks yet, good news is, we already have django-nose: https://admin.fedoraproject.org/pkgdb/acls/name/python-django-nose Sadly, running those tests is not that easy as I thought. Ok, here is how to run the tests: 1) install all the requirements (django, django-nose, celery, mock) 2) patch the tests/settings.py to leave out the coverage stuff (starting line 37) 3) run python setup.py test That does the trick for me. yepp, here too, without patching. You need latest billiard, celery and kombu from rawhide. Sadly, the builders don't have it (yet). SRPM: http://www.matthias-runge.de/fedora/python-django-celery-3.0.4-2.fc17.src.rpm SPEC: http://www.matthias-runge.de/fedora/python-django-celery.spec Oh, sure, you also install nose-cover3 so you don't need to patch the tests. I tried a scratch build and it seems that koji already has the newest versions, but you're missing BR: python-mock [1]. Would you mind adding it and putting the spec + srpm one last time in here, so that I can check before finally approving? Thanks! [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4354079 OK, that's it. [1] I would have sworn to have python-mock included also, but you're right, it was missing! SPEC: http://www.matthias-runge.de/fedora/python-django-celery.spec SRPM: http://www.matthias-runge.de/fedora/python-django-celery-3.0.4-3.fc17.src.rpm [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=4354083 Great. I don't have any other objections. This package is APPROVED. Thank you very much! New Package SCM Request ======================= Package Name: python-django-celery Short Description: Django Celery Integration Owners: mrunge Branches: devel Git done (by process-git-requests). package imported and built. thanks. |