Bug 845689
| Summary: | Review Request: python-django-setuptest - python-django-setuptest | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Luis Bazan <bazanluis20> |
| Component: | Package Review | Assignee: | Toshio Ernie Kuratomi <a.badger> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | a.badger, fdc, notting, package-review |
| Target Milestone: | --- | Flags: | a.badger:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-01-10 22:50:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Luis Bazan
2012-08-03 21:15:37 UTC
$ rpmlint -v python-django-setuptest-0.1.2-2.fc17.src.rpm python-django-setuptest.src: I: checking python-django-setuptest.src: I: enchant-dictionary-not-found en_US python-django-setuptest.src: I: checking-url https://github.com/praekelt/django-setuptest (timeout 10 seconds) python-django-setuptest.src: I: checking-url http://pypi.python.org/packages/source/d/django-setuptest/django-setuptest-0.1.2.tar.gz (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint -v python-django-setuptest-0.1.2-2.fc17.noarch.rpm python-django-setuptest.noarch: I: checking python-django-setuptest.noarch: I: enchant-dictionary-not-found en_US python-django-setuptest.noarch: I: checking-url https://github.com/praekelt/django-setuptest (timeout 10 seconds) 1 packages and 0 specfiles checked; 0 errors, 0 warnings. NEEDSWORK fd62cbbcd1f9bab1acc553dba7aa134a58145860ab029d673099f5ccc1e32ce1 django-setuptest-0.1.2.tar.gz * Name follows the naming guidelines * License is BSD in spec and in code * License files included in package * Spec file is legible * Source matches upstream * No locale files * No C libraries * No bundled libraries * Not relocatable * Package owns all directories it creates * Does not have duplicate files * Macros used consistently * Code, not content * No large docs * Nothing in %doc is used at runtime * Not a GUI app * Does nt own directories owned by other packages * All filenames valid UTF-8 == NEEDSWORK == * Package does not build in koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4356443 - That looks like it's a missing BuildRequires: python-django == rpmlint == python-django-setuptest.noarch: W: spelling-error %description -l en_US py -> pt, p, y python-django-setuptest.src: W: spelling-error %description -l en_US py -> pt, p, y 2 packages and 0 specfiles checked; 0 errors, 2 warnings These are ignorable as py is being used as a filename extension in the %description Ah -- two other cosmetic changes: - BuildRequires: python-devel - BuildRequires: python-setuptools-devel + BuildRequires: python2-devel + BuildRequires: python-setuptools python2-devel is preferred but it's not a big deal. python-devel won't be going away anytime soon. But we don't know about the distant future when python3 is what most people use. python-setuptools-devel will go away eventually. It's just in the python-setuptools package for backwards compatibility since we had it split into a separate subpackage at one time. We shouldn't use it as we will get rid of it in a somewhat near future. Hi SPEC: http://lbazan.fedorapeople.org/python-django-setuptest.spec SRPM: http://lbazan.fedorapeople.org/python-django-setuptest-0.1.2-3.fc17.src.rpm Fixed Regards!! Everything noted is fixed and it builds in koji now: http://koji.fedoraproject.org/koji/taskinfo?taskID=4356602 APPROVED New Package SCM Request ======================= Package Name: python-django-setuptest Short Description: Simple module enabling Django app testing Owners: lbazan Branches: f17 f18 el6 InitialCC: New Package SCM Request ======================= Package Name: python-django-setuptest Short Description: Simple module enabling Django app testing Owners: lbazan Branches: f17 el6 InitialCC: Git done (by process-git-requests). we can close this bug (the package is stable). Best Regards!! Luis, please close the bug yourself next time, or better yet, use bodhi's built-in bugzilla management. See: https://fedoraproject.org/wiki/Bodhi Package built and shipped. Closing. |