Bug 845805 (rubygem-ttfunk)
| Summary: | Review Request: rubygem-ttfunk - Font Metrics Parser for Prawn | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Bohuslav "Slavek" Kabrda <bkabrda> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | bkabrda, notting, package-review |
| Target Milestone: | --- | Flags: | bkabrda:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-25 02:56:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miroslav Suchý
2012-08-05 08:05:24 UTC
Updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-2.fc17.src.rpm I'll take it for a review. - Is there any benefit of moving the various doc files in %install section? The optimal solution, I think, is to leave them in %{gem_instdir} and mark them as %doc there.
- Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3, LICENSE) in the main package and move the others to the -doc subpackage.
- It is customary to exclude cached gem in the RPM packaged gems, please do so.
- %{gem_docdir} should be marked as %doc.
Otherwise the package looks good, so please fix these and post updated SPEC/SRPM so I can take one more look and approve it.
> - Is there any benefit of moving the various doc files in %install section? The > optimal solution, I think, is to leave them in %{gem_instdir} and mark them as > %doc there. It is good habbit on every other package but rubygems. Location is not mandated by guidelines. I already opened discussion about it on packaging mailing lists. > Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3, > LICENSE) in the main package and move the others to the -doc subpackage. So you mean just copy README.rdoc, to -doc package? ok. > It is customary to exclude cached gem in the RPM packaged gems, please do so. done > %{gem_docdir} should be marked as %doc. done Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-3.fc17.src.rpm (In reply to comment #4) > > - Is there any benefit of moving the various doc files in %install section? The > > optimal solution, I think, is to leave them in %{gem_instdir} and mark them as > > %doc there. > > It is good habbit on every other package but rubygems. Location is not > mandated by guidelines. I already opened discussion about it on packaging > mailing lists. > I don't see any such discussion, would you care to post a link here? > > Also, please only leave files related to licensing (COPYING, GPLv2, GPLv3, > > LICENSE) in the main package and move the others to the -doc subpackage. > > So you mean just copy README.rdoc, to -doc package? ok. > I also meant CHANGELOG :) Please move that before importing to dist-git, too. > > It is customary to exclude cached gem in the RPM packaged gems, please do so. > > done > > > %{gem_docdir} should be marked as %doc. > > done > > Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk.spec > SRPM URL: > http://miroslav.suchy.cz/fedora/rubygem-ttfunk/rubygem-ttfunk-1.0.3-3.fc17. > src.rpm The package looks good now. Please move the CHANGELOG file to -doc subpackage, as mentioned above, before importing to dist-git. This package is APPROVED. > I don't see any such discussion, would you care to post a link here? http://lists.fedoraproject.org/pipermail/packaging/2012-August/008598.html > I also meant CHANGELOG :) Please move that before importing to dist-git, too. Will do. New Package SCM Request ======================= Package Name: rubygem-ttfunk Short Description: Font Metrics Parser for Prawn Owners: msuchy Branches: F-18, F-17, F-16, EL-6 InitialCC: Git done (by process-git-requests). rubygem-ttfunk-1.0.3-4.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.fc18 rubygem-ttfunk-1.0.3-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.fc16 rubygem-ttfunk-1.0.3-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.fc17 rubygem-ttfunk-1.0.3-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-ttfunk-1.0.3-4.el6 rubygem-ttfunk-1.0.3-4.fc18 has been pushed to the Fedora 18 testing repository. rubygem-ttfunk-1.0.3-4.fc17 has been pushed to the Fedora 17 stable repository. rubygem-ttfunk-1.0.3-4.fc16 has been pushed to the Fedora 16 stable repository. rubygem-ttfunk-1.0.3-4.el6 has been pushed to the Fedora EPEL 6 stable repository. rubygem-ttfunk-1.0.3-4.fc18 has been pushed to the Fedora 18 stable repository. |