Bug 845819
| Summary: | Review Request: rubygem-ruby-rc4 - Pure Ruby implementation of the RC4 algorithm | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miroslav Suchý <msuchy> |
| Component: | Package Review | Assignee: | Vít Ondruch <vondruch> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | notting, package-review, vondruch |
| Target Milestone: | --- | Flags: | vondruch:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-08-15 13:41:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miroslav Suchý
2012-08-05 10:59:44 UTC
Updated: Spec URL: http://miroslav.suchy.cz/fedora/rubygem-ruby-rc4/rubygem-ruby-rc4.spec SRPM URL: http://miroslav.suchy.cz/fedora/rubygem-ruby-rc4/rubygem-ruby-rc4-0.1.5-2.fc17.src.rpm I'll review this package. * Keep the Readme and License in the original location
- I.e. refer to them as a %{gem_instdir}/LICENSE and %{gem_instdir}/README.md
in the %files section and remove the "rm"
* Test suite
- Please consider running the test suite in the .%{gem_instdir}, which is
convenient place to do so. The test folder in %{_builddir} is just remaining
of gem repackaging.
* Exclude %{gem_cache}
- As always ... ;)
* Use %{_bindir}/rspec
- This could be used in place of BUildRequires: rubygem-rspec
Nevertheless, non of these nits is blocker => APPROVED
New Package SCM Request ======================= Package Name: rubygem-ruby-rc4 Short Description: Pure Ruby implementation of the RC4 algorithm Owners: msuchy Branches: F-18, F-17, F-16, EL-6 InitialCC: Git done (by process-git-requests). > Please consider running the test suite in the .%{gem_instdir},
I will address this in released package.
rubygem-ruby-rc4-0.1.5-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/rubygem-ruby-rc4-0.1.5-3.fc17 rubygem-ruby-rc4-0.1.5-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/rubygem-ruby-rc4-0.1.5-3.fc18 rubygem-ruby-rc4-0.1.5-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-ruby-rc4-0.1.5-4.el6 rubygem-ruby-rc4-0.1.5-4.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/rubygem-ruby-rc4-0.1.5-4.fc16 rubygem-ruby-rc4-0.1.5-3.fc17 has been pushed to the Fedora 17 stable repository. rubygem-ruby-rc4-0.1.5-4.fc16 has been pushed to the Fedora 16 stable repository. rubygem-ruby-rc4-0.1.5-4.el6 has been pushed to the Fedora EPEL 6 stable repository. rubygem-ruby-rc4-0.1.5-3.fc18 has been pushed to the Fedora 18 stable repository. |